public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Pekon Gupta <pekon@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
	bcousson@baylibre.com, linux-omap <linux-omap@vger.kernel.org>,
	Nishanth Menon <nm@ti.com>,
	Robert Nelson <robertcnelson@gmail.com>
Subject: Re: [PATCH v2 1/2] ARM: dts: am335x-bone: add support for beaglebone NAND cape
Date: Mon, 12 May 2014 13:03:54 -0300	[thread overview]
Message-ID: <20140512160354.GA16440@arch.cereza> (raw)
In-Reply-To: <1395300886-383-2-git-send-email-pekon@ti.com>

Pekon,

A few questions regarding this patch, despite the fact I'm not sure it will
ever be included.

On 20 Mar 01:04 PM, Pekon Gupta wrote:
> +			0x70 (MUX_MODE0 | PIN_INPUT_PULLUP )	/* gpmc_wait0.gpmc_wait0 */
> +			0x74 (MUX_MODE7 | PIN_OUTPUT_PULLUP)	/* gpmc_wpn.gpio0_30 */

Is this output pin?

> +			0x7c (MUX_MODE0 | PIN_OUTPUT_PULLUP)	/* gpmc_csn0.gpmc_csn0  */

Again: is this output pin?

> +		gpmc,wait-on-read = "true";
> +		gpmc,wait-on-write = "true";

The devicetree binding says these wait properties are bool, so the above
should be:

		gpmc,wait-on-read;
		gpmc,wait-on-write;

But the problem is that there's no wait-pin defined, so this not enabled.

Could you explain what should be the correct binding? This is very confusing
for me.

Thanks!
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-05-12 16:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20  7:34 [PATCH v2 0/2] add parallel NAND support for TI's new OMAPx and AMxx platforms (Part-2) Pekon Gupta
2014-03-20  7:34 ` [PATCH v2 1/2] ARM: dts: am335x-bone: add support for beaglebone NAND cape Pekon Gupta
2014-05-12 16:03   ` Ezequiel Garcia [this message]
2014-05-16 19:39     ` Gupta, Pekon
2014-03-20  7:34 ` [PATCH v2 2/2] ARM: dts: am437x-gp-evm: add support for parallel NAND flash Pekon Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140512160354.GA16440@arch.cereza \
    --to=ezequiel.garcia@free-electrons.com \
    --cc=bcousson@baylibre.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=pekon@ti.com \
    --cc=robertcnelson@gmail.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox