linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Pekon Gupta <pekon@ti.com>,
	Benoit Cousson <bcousson@baylibre.com>,
	linux-omap <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v4 6/6] ARM: dts: am335x-evm: fix reg and range property of GPMC NAND node
Date: Mon, 12 May 2014 12:44:01 -0700	[thread overview]
Message-ID: <20140512194401.GA5668@atomide.com> (raw)
In-Reply-To: <CABxcv==icXxn74_zz1YQTq2jvuPyDSSh5ZM_NKA1W3SUzD6EKA@mail.gmail.com>

* Javier Martinez Canillas <javier@dowhile0.org> [140510 10:12]:
> Hello Pekon,
> 
> On Fri, May 9, 2014 at 10:46 PM, Pekon Gupta <pekon@ti.com> wrote:
> > 1) NAND device memory is not directly accessible to CPU, its indirectly accessed
> >    via registers. So the 'reg' property for GPMC NAND nodes should be limited to
> >    address range of internal GPMC registers only.
> > 2) Also, minimum granularity of address space under a GPMC chip-select is 16MB
> >    so 'range' property for GPMC NAND node should specify 16MB as its memory-size
> 
> This is true for all SoC using the GPMC right? So we need to do the
> same modification for all OMAP boards to avoid mapping a bigger
> address space unnecessarily.

Yes we should fix them all up. See also the commenting standard I suggested
in the parallel NAND series.

Regards,

Tony

  reply	other threads:[~2014-05-12 19:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-09 20:46 [PATCH v4 3/6] ARM: dts: dra7: add support for parallel NAND flash Pekon Gupta
2014-05-09 20:46 ` [PATCH v4 4/6] ARM: dts: am43xx: fix starting offset of NAND.filesystem MTD partition Pekon Gupta
2014-05-10 17:02   ` Javier Martinez Canillas
2014-05-09 20:46 ` [PATCH v4 5/6] ARM: dts: am43x-epos-evm: fix reg and range property of GPMC NAND node Pekon Gupta
2014-05-13 17:32   ` Tony Lindgren
2014-05-09 20:46 ` [PATCH v4 6/6] ARM: dts: am335x-evm: " Pekon Gupta
2014-05-10 17:11   ` Javier Martinez Canillas
2014-05-12 19:44     ` Tony Lindgren [this message]
2014-05-10 17:57 ` [PATCH v4 3/6] ARM: dts: dra7: add support for parallel NAND flash Javier Martinez Canillas
2014-05-12  7:03   ` Gupta, Pekon
2014-05-12  8:49     ` Javier Martinez Canillas
2014-05-12  9:05       ` Gupta, Pekon
2014-05-12  9:08         ` Javier Martinez Canillas
2014-05-14  8:25         ` Roger Quadros
2014-05-14  8:47           ` Gupta, Pekon
2014-05-14  9:00           ` Roger Quadros
2014-05-14  9:09             ` Gupta, Pekon
2014-05-14  9:17               ` Roger Quadros
2014-05-14  9:23                 ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140512194401.GA5668@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=javier@dowhile0.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=pekon@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).