From: Tony Lindgren <tony@atomide.com>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: AnilKumar Ch <anilkumar@ti.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/1] ARM: OMAP2+: enable LEDS class support
Date: Wed, 14 May 2014 08:10:05 -0700 [thread overview]
Message-ID: <20140514151004.GA18463@atomide.com> (raw)
In-Reply-To: <1400067905-20786-1-git-send-email-javier@dowhile0.org>
* Javier Martinez Canillas <javier@dowhile0.org> [140514 04:46]:
> Commit 5610b8ede ("ARM: OMAP2+: AM33XX: omap2plus_defconfig:
> Add support for few drivers") added support for different
> drivers including GPIO based leds.
>
> But LEDS_GPIO config option depends on LEDS_CLASS which was
> not included so GPIO leds option is not selected. Adding as
> built-in option since the related options are built-in too.
Yeah this is already enabled with the PM related patches as
we can use the n900 debug LEDs to monitor for PM related
regressions. So patch "ARM: dts: Enable N900 keyboard sleep
leds by default" enables CONFIG_LEDS_CLASS, I've sent a pull
request for that few days ago for v3.16.
Regards,
Tony
> Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
> ---
> arch/arm/configs/omap2plus_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> index a4e8d01..0a70170 100644
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig
> @@ -239,6 +239,7 @@ CONFIG_SDIO_UART=y
> CONFIG_MMC_OMAP=y
> CONFIG_MMC_OMAP_HS=y
> CONFIG_NEW_LEDS=y
> +CONFIG_LEDS_CLASS=y
> CONFIG_LEDS_GPIO=y
> CONFIG_LEDS_TRIGGERS=y
> CONFIG_LEDS_TRIGGER_TIMER=y
> --
> 2.0.0.rc0
>
next prev parent reply other threads:[~2014-05-14 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 11:45 [PATCH 1/1] ARM: OMAP2+: enable LEDS class support Javier Martinez Canillas
2014-05-14 15:10 ` Tony Lindgren [this message]
2014-05-14 16:40 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514151004.GA18463@atomide.com \
--to=tony@atomide.com \
--cc=anilkumar@ti.com \
--cc=javier@dowhile0.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).