* [PATCH] ARM: OMAP2+: nand: Fix NAND on OMAP2 and OMAP3 boards
@ 2014-05-14 12:35 Roger Quadros
2014-05-14 15:30 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Roger Quadros @ 2014-05-14 12:35 UTC (permalink / raw)
To: tony
Cc: pekon, balbi, ezequiel.garcia, computersforpeace, linux-mtd,
linux-omap, Roger Quadros
Commit c66d039197e4 broke NAND for non-DT boot on all OMAP2 and OMAP3
boards using board_nand_init(). Following error is seen at boot
[ 0.154998] (null): Unsupported NAND ECC scheme selected
For OMAP2 and OMAP3 platforms, the ecc_opt parameter in platform data
must be set to OMAP_ECC_HAM1_CODE_HW to work properly.
Tested on omap3-beagle c4.
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
arch/arm/mach-omap2/board-flash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/board-flash.c b/arch/arm/mach-omap2/board-flash.c
index ac82512..b6885e4 100644
--- a/arch/arm/mach-omap2/board-flash.c
+++ b/arch/arm/mach-omap2/board-flash.c
@@ -142,7 +142,7 @@ __init board_nand_init(struct mtd_partition *nand_parts, u8 nr_parts, u8 cs,
board_nand_data.nr_parts = nr_parts;
board_nand_data.devsize = nand_type;
- board_nand_data.ecc_opt = OMAP_ECC_BCH8_CODE_HW;
+ board_nand_data.ecc_opt = OMAP_ECC_HAM1_CODE_HW;
gpmc_nand_init(&board_nand_data, gpmc_t);
}
#endif /* CONFIG_MTD_NAND_OMAP2 || CONFIG_MTD_NAND_OMAP2_MODULE */
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: OMAP2+: nand: Fix NAND on OMAP2 and OMAP3 boards
2014-05-14 12:35 [PATCH] ARM: OMAP2+: nand: Fix NAND on OMAP2 and OMAP3 boards Roger Quadros
@ 2014-05-14 15:30 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2014-05-14 15:30 UTC (permalink / raw)
To: Roger Quadros
Cc: pekon, balbi, ezequiel.garcia, computersforpeace, linux-mtd,
linux-omap
* Roger Quadros <rogerq@ti.com> [140514 05:36]:
> Commit c66d039197e4 broke NAND for non-DT boot on all OMAP2 and OMAP3
> boards using board_nand_init(). Following error is seen at boot
>
> [ 0.154998] (null): Unsupported NAND ECC scheme selected
>
> For OMAP2 and OMAP3 platforms, the ecc_opt parameter in platform data
> must be set to OMAP_ECC_HAM1_CODE_HW to work properly.
>
> Tested on omap3-beagle c4.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
Thanks applying into fixes with Cc stable v3.12+.
Regards,
Tony
> arch/arm/mach-omap2/board-flash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/board-flash.c b/arch/arm/mach-omap2/board-flash.c
> index ac82512..b6885e4 100644
> --- a/arch/arm/mach-omap2/board-flash.c
> +++ b/arch/arm/mach-omap2/board-flash.c
> @@ -142,7 +142,7 @@ __init board_nand_init(struct mtd_partition *nand_parts, u8 nr_parts, u8 cs,
> board_nand_data.nr_parts = nr_parts;
> board_nand_data.devsize = nand_type;
>
> - board_nand_data.ecc_opt = OMAP_ECC_BCH8_CODE_HW;
> + board_nand_data.ecc_opt = OMAP_ECC_HAM1_CODE_HW;
> gpmc_nand_init(&board_nand_data, gpmc_t);
> }
> #endif /* CONFIG_MTD_NAND_OMAP2 || CONFIG_MTD_NAND_OMAP2_MODULE */
> --
> 1.8.3.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-14 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-14 12:35 [PATCH] ARM: OMAP2+: nand: Fix NAND on OMAP2 and OMAP3 boards Roger Quadros
2014-05-14 15:30 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).