From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 02/14] ARM: omap2: fix am43xx dependency on l2x0 cache Date: Mon, 16 Jun 2014 02:41:56 -0700 Message-ID: <20140616094156.GA17845@atomide.com> References: <1402675276-538682-1-git-send-email-arnd@arndb.de> <1402675276-538682-3-git-send-email-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:13967 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754820AbaFPJmB (ORCPT ); Mon, 16 Jun 2014 05:42:01 -0400 Content-Disposition: inline In-Reply-To: <1402675276-538682-3-git-send-email-arnd@arndb.de> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, arm@kernel.org, linux-omap@vger.kernel.org * Arnd Bergmann [140613 09:02]: > Commit d941f86fad41b ("ARM: l2c: AM43x: add L2 cache support") enabled > the L2 cache support for the am43xx SoC, but caused a build regression > when the driver for that cache controller is disabled: > > arch/arm/mach-omap2/built-in.o: In function `am43xx_init_early': > :(.init.text+0xb20): undefined reference to `omap_l2_cache_init' > > This did not happen for OMAP4, which has the same call, but enables > the l2x0 driver unconditionally. We could do the same thing for > am43xx, but it seems better to allow turning it off and make the > code work in either case. > > This adds an inline wrapper for omap_l2_cache_init for the disabled > case, and removes the 'select' from OMAP4 so it becomes a user > visible option. > > Signed-off-by: Arnd Bergmann > Cc: linux-omap@vger.kernel.org Acked-by: Tony Lindgren