From: Lee Jones <lee.jones@linaro.org>
To: Keerthy <a0393675@ti.com>
Cc: Keerthy <j-keerthy@ti.com>,
linux-omap@vger.kernel.org, lgirdwood@gmail.com,
broonie@kernel.org, linux-kernel@vger.kernel.org,
sameo@linux.intel.com
Subject: Re: [PATCH 7/9] regulator: palmas: Add palmas_pmic_driver_data structure
Date: Wed, 18 Jun 2014 08:24:36 +0100 [thread overview]
Message-ID: <20140618072436.GA21030@lee--X1> (raw)
In-Reply-To: <53A11D40.7020201@ti.com>
> >>Add palmas_pmic_driver_data structure.
> >>
> >>Signed-off-by: Keerthy <j-keerthy@ti.com>
> >>---
> >> include/linux/mfd/palmas.h | 25 +++++++++++++++++++++++++
> >> 1 file changed, 25 insertions(+)
> >>
> >>diff --git a/include/linux/mfd/palmas.h b/include/linux/mfd/palmas.h
> >>index 8d68452..70f0695 100644
> >>--- a/include/linux/mfd/palmas.h
> >>+++ b/include/linux/mfd/palmas.h
[...]
> >>+struct palmas_pmic_driver_data {
> >>+ int smps_start;
> >>+ int smps_end;
> >>+ int ldo_begin;
> >>+ int ldo_end;
> >>+ int max_reg;
> >>+ struct regs_info *palmas_regs_info;
> >>+ struct of_regulator_match *palmas_matches;
> >>+ struct palmas_sleep_requestor_info *sleep_req_info;
> >>+ int (*smps_register)(struct palmas_pmic *pmic,
> >>+ struct palmas_pmic_driver_data *ddata,
> >>+ struct palmas_pmic_platform_data *pdata,
> >>+ const char *pdev_name,
> >>+ struct regulator_config config);
> >>+ int (*ldo_register)(struct palmas_pmic *pmic,
> >>+ struct palmas_pmic_driver_data *ddata,
> >>+ struct palmas_pmic_platform_data *pdata,
> >>+ const char *pdev_name,
> >>+ struct regulator_config config);
> >Are you sure you need to store all of this stuff?
> >
> >Particularly the match pointer. Do you really re-use it?
>
> Match pointer is used extensively in the palmas_regulator.c.
> This structure is very much used by regulator driver.
On closer inspection, I now see that it's a 'of_regulator_match',
rather than an 'of_match' pointer, which were my initial thoughts. I
think it would have been weird to carry the 'of_match', but the
reality sounds sane.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-06-18 7:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 10:20 [PATCH 0/9] mfd: tps65917: Add support for for TPS65917 PMIC Keerthy
2014-05-28 10:20 ` [PATCH 1/9] mfd: Add DT bindings for tps65917 PMIC Keerthy
2014-05-28 10:20 ` [PATCH 2/9] regulator: palmas: Add tps65917 compatible string Keerthy
2014-05-28 10:20 ` [PATCH 3/9] mfd: palmas: Add tps65917 specific definitions and enums Keerthy
2014-06-17 16:11 ` Lee Jones
2014-06-18 5:07 ` Keerthy
2014-05-28 10:20 ` [PATCH 4/9] mfd: palmas: Add tps65917 support Keerthy
2014-06-17 16:19 ` Lee Jones
2014-06-18 5:06 ` Keerthy
2014-05-28 10:20 ` [PATCH 5/9] regulator: palmas: Shift the reg_info structure definition to the header file Keerthy
2014-06-17 16:32 ` Lee Jones
2014-06-18 5:05 ` Keerthy
2014-05-28 10:20 ` [PATCH 6/9] mfd: palmas: shift the palmas_sleep_requestor_info " Keerthy
2014-06-17 16:33 ` Lee Jones
2014-06-18 5:04 ` Keerthy
2014-05-28 10:20 ` [PATCH 7/9] regulator: palmas: Add palmas_pmic_driver_data structure Keerthy
2014-06-17 16:37 ` Lee Jones
2014-06-18 5:01 ` Keerthy
2014-06-18 7:24 ` Lee Jones [this message]
2014-05-28 10:20 ` [PATCH 8/9] regulator: palmas: add driver data and modularize the probe Keerthy
2014-06-17 16:45 ` Lee Jones
2014-06-18 4:53 ` Keerthy
2014-05-28 10:20 ` [PATCH 9/9] regulator: palmas: Add tps65917 PMIC support Keerthy
2014-06-06 10:59 ` [PATCH 0/9] mfd: tps65917: Add support for for TPS65917 PMIC Keerthy
2014-06-06 12:43 ` Lee Jones
2014-06-06 12:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140618072436.GA21030@lee--X1 \
--to=lee.jones@linaro.org \
--cc=a0393675@ti.com \
--cc=broonie@kernel.org \
--cc=j-keerthy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).