From: Felipe Balbi <balbi@ti.com>
To: George Cherian <george.cherian@ti.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, gregkh@linuxfoundation.org,
balbi@ti.com, zonque@gmail.com, b-liu@ti.com
Subject: Re: [PATCH v6 0/5] Add support for SW babble Control
Date: Mon, 30 Jun 2014 12:30:06 -0500 [thread overview]
Message-ID: <20140630173006.GJ31442@saruman.home> (raw)
In-Reply-To: <1401096012-6895-1-git-send-email-george.cherian@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1460 bytes --]
Hi,
On Mon, May 26, 2014 at 02:50:07PM +0530, George Cherian wrote:
> Series add support for SW babble control logic found in
> new silicon versions of AM335x. Runtime differentiation of
> silicon version is done by checking the BABBLE_CTL register.
> For newer silicon the register default value read is 0x4 and
> for older versions its 0x0.
>
> Patch 1 -> Handle Babble only if MUSB is in HOST mode
> Patch 2 -> Convert recover work to delayed work.
> Patch 3 -> usb_phy_vbus_(off/_on) are NOPs for am335x PHY
> so use usb_phy(_shutdown/_init) in musb_platform_reset()
> Patch 4 -> Add return value for musb_platform_reset() in prepration
> to support SW babble_ctrl
> Patch 5 -> Add and Enable sw babble control for newer silicon
>
> v5 -> v6 : Squash patch 5 and 6 form v5 to avoid build warnings.
>
> v4 -> v5 : Added a debug print before resetting MUSB.
> changed a musb_readb to dsps_readb introduced in Patch#5 of v4.
>
> v3 -> v4 : Fixes an issue in gagdet mode - BUS RESET should not
> be handled as a BABBLE. Added a check for the same.(Patch #1)
> Enable sw babble control properly (Patch #6)
>
> v2 -> v3 : Modify musb_platform_reset() to return zero on success.
this series doesn't apply anymore, can you please rebase on top of my
testing/next which I just pushed ?
Thank you
ps: while doing that, please also add Bin's Tested-by which he has
already given ;-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-06-30 17:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 9:20 [PATCH v6 0/5] Add support for SW babble Control George Cherian
2014-05-26 9:20 ` [PATCH v6 1/5] usb: musb: core: Handle Babble condition only in HOST mode George Cherian
2014-06-19 10:44 ` Tony Lindgren
2014-06-19 16:01 ` Felipe Balbi
2014-05-26 9:20 ` [PATCH v6 2/5] usb: musb: core: Convert babble recover work to delayed work George Cherian
2014-05-26 9:20 ` [PATCH v6 3/5] usb: musb: dsps: Call usb_phy(_shutdown/_init) during musb_platform_reset() George Cherian
2014-05-26 9:20 ` [PATCH v6 4/5] usb: musb: core: Convert the musb_platform_reset to have a return value George Cherian
2014-05-26 9:20 ` [PATCH v6 5/5] usb: musb: dsps: Add the sw_babble_control() and Enable for newer silicon George Cherian
2014-06-03 19:00 ` [PATCH v6 0/5] Add support for SW babble Control Bin Liu
2014-06-30 17:30 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140630173006.GJ31442@saruman.home \
--to=balbi@ti.com \
--cc=b-liu@ti.com \
--cc=george.cherian@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).