From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: OMAP2+: l2c: squelch warning dump on power control setting Date: Tue, 8 Jul 2014 01:29:48 -0700 Message-ID: <20140708082948.GE28884@atomide.com> References: <20140702081142.GU28884@atomide.com> <20140707104727.GM28884@atomide.com> <20140707104944.GS3705@n2100.arm.linux.org.uk> <20140707110249.GO28884@atomide.com> <53BA8983.3030803@ti.com> <20140707121512.GT3705@n2100.arm.linux.org.uk> <20140707123925.GW28884@atomide.com> <20140707134008.GU3705@n2100.arm.linux.org.uk> <20140707151024.GJ5582@saruman.home> <53BB7980.2060909@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:10679 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752936AbaGHI3t (ORCPT ); Tue, 8 Jul 2014 04:29:49 -0400 Content-Disposition: inline In-Reply-To: <53BB7980.2060909@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Sekhar Nori Cc: balbi@ti.com, Russell King - ARM Linux , Linux OMAP Mailing List , Linux ARM Mailing List , Nishanth Menon , Santosh Shilimkar * Sekhar Nori [140707 21:56]: > On Monday 07 July 2014 08:40 PM, Felipe Balbi wrote: > > On Mon, Jul 07, 2014 at 02:40:08PM +0100, Russell King - ARM Linux wrote: > >> --- a/arch/arm/mm/cache-l2x0.c > >> +++ b/arch/arm/mm/cache-l2x0.c > >> @@ -732,7 +732,7 @@ static int l2c310_cpu_enable_flz(struct notifier_block *nb, unsigned long act, v > >> > >> static void __init l2c310_enable(void __iomem *base, u32 aux, unsigned num_lock) > >> { > >> - unsigned rev = readl_relaxed(base + L2X0_CACHE_ID) & L2X0_CACHE_ID_PART_MASK; > >> + unsigned rev = readl_relaxed(base + L2X0_CACHE_ID) & L2X0_CACHE_ID_RTL_MASK; > >> bool cortex_a9 = read_cpuid_part() == ARM_CPU_PART_CORTEX_A9; > > > > even with this change, l2c still tries to write to power control > > register, at least on AM437x. Looking a little deeper here, AM437x > > identifies itself as l2c PL310 r3p3, which should have power control > > register, but aparentely there's no way to write that register. I'll > > file a bug to our ROM team, but we will certainly need a way to > > workaround this inside omap4-common.c > > Looks like we need both my patch as well as Russell's patch. I can > respin my patch with the pr_info_once() dropped if it helps further > reduce boot noise. In that case I'm fine with the original patch in this series. Russell, got any better ideas? Regards, Tony