Re: [PATCH v2 5/7] ARM: dts: AM437x: Add TPS65218 device tree nodes

Felipe Balbi
2014-07-08T13:39:20Z

[-- Attachment #1: Type: text/plain, Size: 2636 bytes --]

On Tue, Jul 08, 2014 at 03:46:35PM +0530, Keerthy wrote:
> Add TPS65218 device tree nodes. i2c clock frequency setting
> also added as part of tps65218 nodes addition. As i2c clock
> enabling is required.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>
> Changes in V2:
> *Added dcdc3, dcdc5, dcdc6 nodes

same thing wrt dcdc4

>
> arch/arm/boot/dts/am437x-gp-evm.dts | 58 +++++++++++++++++++++++++++++++++++
> 1 file changed, 58 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
> index 85ca430..f0422c2 100644
> --- a/arch/arm/boot/dts/am437x-gp-evm.dts
> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts
> @@ -260,6 +260,64 @@
> status = "okay";
> pinctrl-names = "default";
> pinctrl-0 = <&i2c0_pins>;
> + clock-frequency = <400000>;
> +
> + tps65218: tps65218@24 {
> + reg = <0x24>;
> + compatible = "ti,tps65218";
> + interrupts = <GIC_SPI 7 IRQ_TYPE_NONE>; /* NMIn */
> + interrupt-parent = <&gic>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> +
> + dcdc1: regulator-dcdc1 {
> + compatible = "ti,tps65218-dcdc1";
> + regulator-name = "vdd_core";
> + regulator-min-microvolt = <912000>;
> + regulator-max-microvolt = <1144000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + dcdc2: regulator-dcdc2 {
> + compatible = "ti,tps65218-dcdc2";
> + regulator-name = "vdd_mpu";
> + regulator-min-microvolt = <912000>;
> + regulator-max-microvolt = <1378000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + dcdc3: regulator-dcdc3 {
> + compatible = "ti,tps65218-dcdc3";
> + regulator-name = "vdcdc3";
> + regulator-min-microvolt = <1350000>;
> + regulator-max-microvolt = <1350000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };

add a blank line here

Reviewed-by: Felipe Balbi <balbi@ti.com>

> + dcdc5: regulator-dcdc5 {
> + compatible = "ti,tps65218-dcdc5";
> + regulator-name = "v1_0bat";
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1000000>;
> + };
> +
> + dcdc6: regulator-dcdc6 {
> + compatible = "ti,tps65218-dcdc6";
> + regulator-name = "v1_8bat";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> + ldo1: regulator-ldo1 {
> + compatible = "ti,tps65218-ldo1";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> + };
> };
>
> &i2c1 {
> --
> 1.7.9.5
>

--
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]