From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 6/8] ARM: OMAP2+: timer: Fix error message to not use hwmod structure Date: Mon, 21 Jul 2014 04:09:02 -0700 Message-ID: <20140721110902.GY18374@atomide.com> References: <1398216429-4681-1-git-send-email-joelf@ti.com> <1398216429-4681-7-git-send-email-joelf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1398216429-4681-7-git-send-email-joelf@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Joel Fernandes Cc: Rob Herring , Linux OMAP List , Linux ARM Kernel List , Linux Kernel Mailing List List-Id: linux-omap@vger.kernel.org * Joel Fernandes [140422 18:27]: > oh->name is no longer used, correct the error message. I guess this error is created by one of the patchs in this series? So maybe fold it into the patch creating this error? Regards, Tony > Signed-off-by: Joel Fernandes > --- > arch/arm/mach-omap2/timer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c > index 4fcfd7a..519ccfd 100644 > --- a/arch/arm/mach-omap2/timer.c > +++ b/arch/arm/mach-omap2/timer.c > @@ -331,8 +331,8 @@ static int __init omap_dm_timer_init_one(struct omap_dm_timer *timer, > if (clk_get_parent(timer->fclk) != src) { > r = clk_set_parent(timer->fclk, src); > if (r < 0) { > - pr_warn("%s: %s cannot set source\n", __func__, > - oh->name); > + pr_warn("%s: cannot set timer's source\n", __func__); > + WARN_ON(1); > clk_put(src); > return r; > } > -- > 1.7.9.5 >