linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: linux-omap@vger.kernel.org, "Sebastian Reichel" <sre@kernel.org>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Pavel Machek" <pavel@ucw.cz>
Subject: Re: Nokia N900 FB regression?
Date: Fri, 25 Jul 2014 04:13:48 -0700	[thread overview]
Message-ID: <20140725111347.GD29045@atomide.com> (raw)
In-Reply-To: <20140724200100.GA5336@drone.musicnaut.iki.fi>

* Aaro Koskinen <aaro.koskinen@iki.fi> [140724 13:03]:
> Hi,
> 
> On Wed, Jul 23, 2014 at 12:37:06AM -0700, Tony Lindgren wrote:
> > * Aaro Koskinen <aaro.koskinen@iki.fi> [140722 14:25]:
> > > Hi,
> > > 
> > > Somewhere between 3.16-rc2 and rc6 (I was on holidays...) I noticed
> > > the framebuffer stopped working on N900 (nothing on screen).
> > > 
> > > I bisected this to 9188883fd66e9809e93e06d5bbd49cf99a6cdbee (ARM: dts:
> > > Enable twl4030 off-idle configuration for selected omaps).
> > > With this commit reverted, I can see the Tux again with 3.16-rc6.
> > > 
> > > Any ideas?
> > 
> > Hmm, OK yeah that enables the deeper idle states. I have tested
> > this on n900, but only have remote access to it so could not see
> > the framebuffer.
> > 
> > Sounds like there's some twl regulator that we cannot idle
> > by default on n900. Here are the steps to narrow it down:
> > 
> > 1. Try ti,twl4030-power-idle in omap3-n900.dts instead of
> >    ti,twl4030-power-idle-osc-off. This probably won't help
> >    unless you're enabling off-idle though, so if it does not
> >    help, just keep on using ti,twl4030-power-idle-osc-off.
> > 
> > 2. Try commenting out one or more of the TWL_REMAP_SLEEP or
> >    TWL_REMAP_OFF lines in omap3_idle_rconfig in file
> >    drivers/mfd/twl4030-power.c. That's the recommended init
> >    sequence like the comments in the code mention. Chances
> >    are we're missing a regulator_get somewhere but finding
> >    out which one in omap3_idle_rconfig will help narrow it
> >    down :)
> 
> It's VAUX1 - commenting that out alone fixes the issue. But I think we
> are defining that one properly in the DTS (vdds_sdi-supply = <&vaux1>),
> and also I checked that sdi_init_regulator() succeeds...

OK, looks like the LCD panel is also using V28 from vaux1. It
goes to the "Main flex connector" pin 26.

It also seems that other devices are also using V28 like
accelerometer, main camera cover switch, usd card hot-swap
detection sensor, tvout analog switch, fm transmitter.. And
it's marked as regulator-always-on because of battery cover
switch.

So I'll just send a patch to disable the twl configuration
for n900 for now as anything else would be quite intrusive. I'll
look into it more later on once I have access to my n900.
 
> BTW, this issue can be also detected without seeing the framebuffer,
> from dmesg:
> 
> # dmesg|grep omapfb
> [    2.785705] omapfb omapfb: no displays
> [    2.786041] omapfb omapfb: failed to setup omapfb
> [    2.786102] platform omapfb: Driver omapfb requests probe deferral
> [    4.038055] acx565akm spi1.2: omapfb: acx565akm rev ab LCD detected
> [    5.421325] omapfb omapfb: Failed to enable display 'lcd'
> [    5.431335] omapfb omapfb: failed to initialize default display
> [    5.450408] omapfb omapfb: failed to setup omapfb
> [    5.455444] omapfb: probe of omapfb failed with error -1

OK thanks. I bet I was doing testing on omap2plus_defconfig
only that does not even have the LCD enabled.

Regards,

Tony

      reply	other threads:[~2014-07-25 11:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22 21:23 Nokia N900 FB regression? Aaro Koskinen
2014-07-22 22:02 ` Nick Krause
2014-07-22 22:16   ` Nick Krause
2014-07-23  7:37 ` Tony Lindgren
2014-07-23 15:22   ` Nick Krause
2014-07-24 20:01   ` Aaro Koskinen
2014-07-25 11:13     ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140725111347.GD29045@atomide.com \
    --to=tony@atomide.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=linux-omap@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).