From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v3 1/7] ARM: l2c: Refactor the driver to use commit-like interface Date: Sat, 2 Aug 2014 23:09:40 +0100 Message-ID: <20140802220940.GW3705@n2100.arm.linux.org.uk> References: <1405615142-21426-1-git-send-email-t.figa@samsung.com> <1405615142-21426-2-git-send-email-t.figa@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1405615142-21426-2-git-send-email-t.figa@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Tomasz Figa Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kukjin Kim , lauraa@codeaurora.org, linux-omap@vger.kernel.org, linus.walleij@linaro.org, santosh.shilimkar@ti.com, tony@atomide.com, drake@endlessm.com, Marek Szyprowski , Tomasz Figa , loeliger@gmail.com List-Id: linux-omap@vger.kernel.org On Thu, Jul 17, 2014 at 06:38:56PM +0200, Tomasz Figa wrote: > Certain implementations of secure hypervisors (namely the one found on > Samsung Exynos-based boards) do not provide access to individual L2C > registers. This makes the .write_sec()-based interface insufficient and > provoking ugly hacks. > > This patch is first step to make the driver not rely on availability of > writes to individual registers. This is achieved by refactoring the > driver to use a commit-like operation scheme: all register values are > prepared first and stored in an instance of l2x0_regs struct and then a > single callback is responsible to flush those values to the hardware. This isn't going to work very well... > +static const struct l2c_init_data *l2x0_data; So you keep a pointer to the init data... > +static void l2c_resume(void) > +{ > + l2x0_data->enable(l2x0_base, l2x0_saved_regs.aux_ctrl, > + l2x0_data->num_lock); which you dereference at resume time... > static const struct l2c_init_data l2c210_data __initconst = { but the structures which get assigned to the pointer are marked __initconst. That's not going to work very well. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net.