From: Tony Lindgren <tony@atomide.com>
To: "Dr. H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Lee Jones <lee.jones@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Marek Belisko <marek@goldelico.com>,
linux-omap@vger.kernel.org
Subject: Re: PROBLEM: bindings for drivers/mfd/twl4030-power.c
Date: Mon, 25 Aug 2014 14:26:54 -0700 [thread overview]
Message-ID: <20140825212652.GR17254@atomide.com> (raw)
In-Reply-To: <FAC7D7E5-1D05-4D63-821F-C56D3AAA8FF9@goldelico.com>
* Dr. H. Nikolaus Schaller <hns@goldelico.com> [140817 08:46]:
> I am trying to make ti,use_poweroff work on 3.17-rc1 for the GTA04 board.
> Poweroff was broken for a while and I found that the driver isn't loaded at all.
>
> It appears to me that commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
> did rename the compatible entry from "ti,twl4030-power" to "ti,twl4030-power-reset"
> but this was not documented in the bindings and of course our DT does not
> match.
>
> Even your commit message talks about "ti,twl4030-power" although I can't find it
> in the code.
Hmm sorry did I accidentally remove ti,twl4030-power? If so, that should
be added back for sure. Do you have a patch for that already?
> Are "ti,twl4030-power" and "ti,twl4030-power-reset" doing the same?
No, they are separate where ti,twl4030-power does not configure the
twl4030 in any way where ti,twl4030-power-reset configures the warm
reset sequence.
For gta04, what you really want is to use ti,twl4030-power-idle or
even ti,twl4030-power-idle-osc-off if the board is wired to support
cutting off the oscillator.
And you probably also want to configure some wake-up interrupts at least
for the the UARTs in the board specific .dts file, see for example the
UART3 in the existing board files that have:
interrupts-extended = <&intc 74 &omap3_pmx_core OMAP3_UART3_RX>;
Regards,
Tony
next parent reply other threads:[~2014-08-25 21:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <FAC7D7E5-1D05-4D63-821F-C56D3AAA8FF9@goldelico.com>
2014-08-25 21:26 ` Tony Lindgren [this message]
2014-09-01 16:54 ` PROBLEM: bindings for drivers/mfd/twl4030-power.c Dr. H. Nikolaus Schaller
2014-09-03 18:45 ` Tony Lindgren
2014-09-03 18:50 ` Nishanth Menon
2014-09-03 19:02 ` Tony Lindgren
2014-09-03 19:13 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140825212652.GR17254@atomide.com \
--to=tony@atomide.com \
--cc=hns@goldelico.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=marek@goldelico.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).