From: Felipe Balbi <balbi@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: kishon@ti.com, balbi@ti.com, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/5] usb: phy: twl4030-usb: Remove unused irq_enabled
Date: Wed, 27 Aug 2014 21:20:53 -0500 [thread overview]
Message-ID: <20140828022051.GB5273@saruman.home> (raw)
In-Reply-To: <1409182091-31191-2-git-send-email-tony@atomide.com>
[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]
Hi,
On Wed, Aug 27, 2014 at 04:28:07PM -0700, Tony Lindgren wrote:
> It's not being used any longer.
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/phy/phy-twl4030-usb.c | 2 --
> drivers/usb/phy/phy-twl6030-usb.c | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/drivers/phy/phy-twl4030-usb.c b/drivers/phy/phy-twl4030-usb.c
> index 9cd33a4..bc28ecc 100644
> --- a/drivers/phy/phy-twl4030-usb.c
> +++ b/drivers/phy/phy-twl4030-usb.c
> @@ -164,7 +164,6 @@ struct twl4030_usb {
> enum omap_musb_vbus_id_status linkstat;
> bool vbus_supplied;
> u8 asleep;
> - bool irq_enabled;
>
> struct delayed_work id_workaround_work;
> };
> @@ -755,7 +754,6 @@ static int twl4030_usb_probe(struct platform_device *pdev)
> * set_host() and/or set_peripheral() ... OTG_capable boards
> * need both handles, otherwise just one suffices.
> */
> - twl->irq_enabled = true;
> status = devm_request_threaded_irq(twl->dev, twl->irq, NULL,
> twl4030_usb_irq, IRQF_TRIGGER_FALLING |
> IRQF_TRIGGER_RISING | IRQF_ONESHOT, "twl4030_usb", twl);
can you split this into two patches ? drivers/phy will be taken by
Kishon and drivers/usb/phy by me. another possibility is that I get an
Acked-by from Kishon and I can take $subject as is.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-28 2:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 23:28 [PATCH 0/5] Clean-up for twl4030-usb Tony Lindgren
2014-08-27 23:28 ` [PATCH 1/5] usb: phy: twl4030-usb: Remove unused irq_enabled Tony Lindgren
2014-08-28 2:20 ` Felipe Balbi [this message]
[not found] ` <20140828022051.GB5273-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2014-08-28 18:14 ` Tony Lindgren
2014-08-27 23:28 ` [PATCH 2/5] usb: phy: twl4030-usb: Simplify phy init to use runtime PM Tony Lindgren
2014-08-27 23:28 ` [PATCH 3/5] usb: phy: twl4030-usb: Move code from twl4030_phy_power to the runtime PM calls Tony Lindgren
[not found] ` <1409182091-31191-4-git-send-email-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-09-04 13:50 ` Kishon Vijay Abraham I
2014-09-04 17:07 ` Tony Lindgren
2014-09-08 14:25 ` Kishon Vijay Abraham I
2014-09-08 16:34 ` Tony Lindgren
2014-08-27 23:28 ` [PATCH 4/5] usb: phy: twl4030-usb: Remove asleep and rely on runtime PM Tony Lindgren
2014-08-27 23:28 ` [PATCH 5/5] usb: phy: twl4030-usb: Use mutex instead of spinlock for protecting the data Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140828022051.GB5273@saruman.home \
--to=balbi@ti.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).