From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v2 1/3] nand: omap2: Add support for flash-based bad block table Date: Tue, 9 Sep 2014 10:27:08 -0300 Message-ID: <20140909132708.GA3315@arch.hh.imgtec.org> References: <1410175636-4036-1-git-send-email-ezequiel@vanguardiasur.com.ar> <1410175636-4036-2-git-send-email-ezequiel@vanguardiasur.com.ar> <540EBBEC.0@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-qa0-f41.google.com ([209.85.216.41]:52771 "EHLO mail-qa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751547AbaIIN2X (ORCPT ); Tue, 9 Sep 2014 09:28:23 -0400 Received: by mail-qa0-f41.google.com with SMTP id f12so327472qad.28 for ; Tue, 09 Sep 2014 06:28:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <540EBBEC.0@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Roger Quadros Cc: Brian Norris , linux-mtd@lists.infradead.org, Guido =?iso-8859-1?Q?Mart=EDnez?= , Tony Lindgren , linux-omap@vger.kernel.org On 09 Sep 11:35 AM, Roger Quadros wrote: > Ezequiel, > > On 09/08/2014 02:27 PM, Ezequiel Garcia wrote: > > This commit adds a new platform-data boolean property that enables use > > of a flash-based bad block table. This can also be enabled by setting > > the 'nand-on-flash-bbt' devicetree property. > > I'm not much aware of how on-flash-BBT works internally, but will it break things if > we keep on-flash-BBT "enabled" as the default option and add a DT property only to > explicitly disable the on-flash-BBT? > No, that wouldn't work because the DT property already exists and it works to enable the flash BBT when it's present. Documentation/devicetree/bindings/mtd/nand.txt Of course, we can add a new no-nand-on-flash-bbt, but I really don't see the point. Users can just put the property in all the devicetree board files where it's needed. And moreover, I don't want to change the default behavior of the driver; it's better to allow to *add* a new feature, if such feature is desired. Otherwise, users with some data in a flash's last blocks would be wiped and replaced with the BBT. -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar