From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Felipe Balbi <balbi@ti.com>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Nicolas Pitre <nico@linaro.org>
Subject: Re: [PATCH] arm: arm: fiq: fix build breakage with CONFIG_FIQ
Date: Thu, 18 Sep 2014 14:49:56 +0100 [thread overview]
Message-ID: <20140918134956.GG12379@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20140918015127.GA5745@saruman.home>
On Wed, Sep 17, 2014 at 08:51:28PM -0500, Felipe Balbi wrote:
> Hi,
>
> On Wed, Sep 17, 2014 at 04:29:03PM -0700, Daniel Thompson wrote:
> > On 17/09/14 13:01, Felipe Balbi wrote:
> > > commit e1add97 (ARM: 8150/2: fiq: Replace default FIQ handler)
> > > has a typo which causes build breakage whenever CONFIG_FIQ is
> > > set.
> > >
> > > The bug is very clear as can be noted that a new struct pt_regs
> > > def_fiq_regs was defined but code uses dfl_fiq_regs.
> >
> > Quite so. My fault.
> >
> > This error was picked up by Olof's autobuilder and I have offered
> > a fix as 8150/3 (posted to mailing list in this thread
> > http://thread.gmane.org/gmane.linux.kernel/1789554 ).
>
> aaa, alright. I missed that one :-)
>
> > Your fix and mine are slightly different (I standardised on
> > dfl_fiq_regs) but both approaches should be functionally identical.
>
> sure thing, no issues. I reckon it should be in next within the next
> couple days ?
Should be in the next next. It missed last night's sfr pull.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
prev parent reply other threads:[~2014-09-18 13:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 20:01 [PATCH] arm: arm: fiq: fix build breakage with CONFIG_FIQ Felipe Balbi
2014-09-17 23:29 ` Daniel Thompson
2014-09-18 1:51 ` Felipe Balbi
2014-09-18 13:49 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140918134956.GG12379@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=balbi@ti.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.thompson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nico@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).