From: Wolfram Sang <wsa@the-dreams.de>
To: Roger Quadros <rogerq@ti.com>
Cc: wg@grandegger.com, mkl@pengutronix.de, tony@atomide.com,
tglx@linutronix.de, mugunthanvnm@ti.com, george.cherian@ti.com,
balbi@ti.com, nsekhar@ti.comnm@ti.com,
sergei.shtylyov@cogentembedded.com, linux-omap@vger.kernel.org,
linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 2/3] net: can: c_can: Add syscon/regmap RAMINIT mechanism
Date: Tue, 30 Sep 2014 15:52:26 +0200 [thread overview]
Message-ID: <20140930135226.GO1325@katana> (raw)
In-Reply-To: <542AB137.30507@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1414 bytes --]
> >> +- ti,raminit-syscon : Handle to system control region that contains the
> >> + RAMINIT register. If specified, the second memory resource
> >> + in the reg property must index into the RAMINIT
> >> + register within the syscon region
> >
> > There seems to be a simple "syscon" property these days.
>
> I had used plain "syscon" in the earlier revisions but was asked to make it a TI specific
> property since only TI uses this mechanism.
I see, when was that? Currently, it looks messy :( Grepping through the
dts files in 3.17-rc7, I see that bcm7445 uses "syscon" and variants
with prefixes, STE uses it, too. Samsung uses "samsung,syscon-phandle",
st uses "st,syscon"...
The MACID readout patches for AM335x (just applied right now) also use
"syscon": https://patchwork.ozlabs.org/patch/394289/
I'd vote for a generic "syscon" to be OK, yet I guess the DT maintainers
will have the final word.
> >> +- ti,raminit-start-bit : Bit posistion of START bit in the RAMINIT register
> >> +- ti,raminit-done-bit : Bit position of DONE bit in the RAMINIT register
> >
> > This should not be encoded in DT! This is not describing hardware setup.
> > The driver should know where the bits are for the syscon phandle,
> > depending on which SoC it runs...
> >
> OK. I'll think of matching the compatible ID with SOC specific data in the driver.
Great, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-09-30 13:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 14:31 [PATCH v2 0/3] net: can: Use syscon regmap for TI specific RAMINIT register Roger Quadros
2014-09-09 14:31 ` [PATCH v2 1/3] can: c_can_platform: Fix c_can_hw_raminit_ti() and add timeout Roger Quadros
2014-09-09 14:34 ` Marc Kleine-Budde
2014-09-09 14:39 ` Roger Quadros
2014-09-16 14:13 ` Marc Kleine-Budde
2014-09-09 14:34 ` Nishanth Menon
2014-09-09 14:45 ` Roger Quadros
2014-09-09 14:51 ` Nishanth Menon
2014-09-09 14:54 ` Roger Quadros
2014-09-09 14:31 ` [PATCH v2 2/3] net: can: c_can: Add syscon/regmap RAMINIT mechanism Roger Quadros
2014-09-30 13:26 ` Wolfram Sang
2014-09-30 13:33 ` Roger Quadros
2014-09-30 13:52 ` Wolfram Sang [this message]
2014-09-30 13:58 ` Roger Quadros
2014-09-30 14:19 ` Wolfram Sang
2014-09-30 14:22 ` Marc Kleine-Budde
2014-09-30 14:49 ` Wolfram Sang
2014-09-30 15:01 ` Marc Kleine-Budde
2014-09-30 15:25 ` Wolfram Sang
2014-09-30 16:04 ` Marc Kleine-Budde
2014-10-01 8:45 ` Roger Quadros
2014-10-01 8:47 ` Marc Kleine-Budde
2014-10-01 9:06 ` Roger Quadros
2014-10-01 10:01 ` Marc Kleine-Budde
2014-10-01 10:12 ` Roger Quadros
2014-10-01 10:26 ` Marc Kleine-Budde
2014-10-01 10:43 ` Wolfram Sang
2014-10-01 10:57 ` Roger Quadros
2014-10-01 11:06 ` Marc Kleine-Budde
2014-10-01 11:10 ` Wolfram Sang
2014-10-01 11:11 ` Marc Kleine-Budde
2014-09-30 13:45 ` Marc Kleine-Budde
2014-09-30 14:02 ` Roger Quadros
2014-09-30 14:11 ` Marc Kleine-Budde
2014-09-09 14:31 ` [PATCH v2 3/3] net: can: c_can: Add support for START pulse in RAMINIT sequence Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140930135226.GO1325@katana \
--to=wsa@the-dreams.de \
--cc=balbi@ti.com \
--cc=george.cherian@ti.com \
--cc=mkl@pengutronix.de \
--cc=mugunthanvnm@ti.com \
--cc=nsekhar@ti.comnm \
--cc=rogerq@ti.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).