* [PATCH] watchdog: Fix omap watchdogs to enable the magic close bit
@ 2014-10-14 19:25 Tony Lindgren
2014-10-14 20:01 ` Guenter Roeck
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Tony Lindgren @ 2014-10-14 19:25 UTC (permalink / raw)
To: Wim Van Sebroeck; +Cc: linux-watchdog, linux-omap, Thomas Dziedzic
This allows testing the watchdog easily with distros just by
doing pkill -9 watchdog.
Reported-by: Thomas Dziedzic <gostrc@gmail.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
--- a/drivers/watchdog/omap_wdt.c
+++ b/drivers/watchdog/omap_wdt.c
@@ -189,7 +189,7 @@ static int omap_wdt_set_timeout(struct watchdog_device *wdog,
}
static const struct watchdog_info omap_wdt_info = {
- .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING,
+ .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING,
.identity = "OMAP Watchdog",
};
--- a/drivers/watchdog/retu_wdt.c
+++ b/drivers/watchdog/retu_wdt.c
@@ -94,7 +94,7 @@ static int retu_wdt_set_timeout(struct watchdog_device *wdog,
}
static const struct watchdog_info retu_wdt_info = {
- .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING,
+ .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING,
.identity = "Retu watchdog",
};
--- a/drivers/watchdog/twl4030_wdt.c
+++ b/drivers/watchdog/twl4030_wdt.c
@@ -57,7 +57,7 @@ static int twl4030_wdt_set_timeout(struct watchdog_device *wdt,
}
static const struct watchdog_info twl4030_wdt_info = {
- .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING,
+ .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING,
.identity = "TWL4030 Watchdog",
};
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] watchdog: Fix omap watchdogs to enable the magic close bit
2014-10-14 19:25 [PATCH] watchdog: Fix omap watchdogs to enable the magic close bit Tony Lindgren
@ 2014-10-14 20:01 ` Guenter Roeck
2014-10-14 20:09 ` Aaro Koskinen
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Guenter Roeck @ 2014-10-14 20:01 UTC (permalink / raw)
To: Tony Lindgren
Cc: Wim Van Sebroeck, linux-watchdog, linux-omap, Thomas Dziedzic
On Tue, Oct 14, 2014 at 12:25:19PM -0700, Tony Lindgren wrote:
> This allows testing the watchdog easily with distros just by
> doing pkill -9 watchdog.
>
> Reported-by: Thomas Dziedzic <gostrc@gmail.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
>
Good catch.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> --- a/drivers/watchdog/omap_wdt.c
> +++ b/drivers/watchdog/omap_wdt.c
> @@ -189,7 +189,7 @@ static int omap_wdt_set_timeout(struct watchdog_device *wdog,
> }
>
> static const struct watchdog_info omap_wdt_info = {
> - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING,
> + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING,
> .identity = "OMAP Watchdog",
> };
>
> --- a/drivers/watchdog/retu_wdt.c
> +++ b/drivers/watchdog/retu_wdt.c
> @@ -94,7 +94,7 @@ static int retu_wdt_set_timeout(struct watchdog_device *wdog,
> }
>
> static const struct watchdog_info retu_wdt_info = {
> - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING,
> + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING,
> .identity = "Retu watchdog",
> };
>
> --- a/drivers/watchdog/twl4030_wdt.c
> +++ b/drivers/watchdog/twl4030_wdt.c
> @@ -57,7 +57,7 @@ static int twl4030_wdt_set_timeout(struct watchdog_device *wdt,
> }
>
> static const struct watchdog_info twl4030_wdt_info = {
> - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING,
> + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING,
> .identity = "TWL4030 Watchdog",
> };
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] watchdog: Fix omap watchdogs to enable the magic close bit
2014-10-14 19:25 [PATCH] watchdog: Fix omap watchdogs to enable the magic close bit Tony Lindgren
2014-10-14 20:01 ` Guenter Roeck
@ 2014-10-14 20:09 ` Aaro Koskinen
2014-10-15 14:42 ` Felipe Balbi
[not found] ` <20141014192518.GH4972-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
3 siblings, 0 replies; 7+ messages in thread
From: Aaro Koskinen @ 2014-10-14 20:09 UTC (permalink / raw)
To: Tony Lindgren
Cc: Wim Van Sebroeck, linux-watchdog, linux-omap, Thomas Dziedzic
Hi,
On Tue, Oct 14, 2014 at 12:25:19PM -0700, Tony Lindgren wrote:
> This allows testing the watchdog easily with distros just by
> doing pkill -9 watchdog.
>
> Reported-by: Thomas Dziedzic <gostrc@gmail.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Acked-by: Aaro Koskinen <aaro.koskinen@iki.fi>
A.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] watchdog: Fix omap watchdogs to enable the magic close bit
2014-10-14 19:25 [PATCH] watchdog: Fix omap watchdogs to enable the magic close bit Tony Lindgren
2014-10-14 20:01 ` Guenter Roeck
2014-10-14 20:09 ` Aaro Koskinen
@ 2014-10-15 14:42 ` Felipe Balbi
[not found] ` <20141014192518.GH4972-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
3 siblings, 0 replies; 7+ messages in thread
From: Felipe Balbi @ 2014-10-15 14:42 UTC (permalink / raw)
To: Tony Lindgren
Cc: Wim Van Sebroeck, linux-watchdog, linux-omap, Thomas Dziedzic
[-- Attachment #1: Type: text/plain, Size: 1751 bytes --]
On Tue, Oct 14, 2014 at 12:25:19PM -0700, Tony Lindgren wrote:
> This allows testing the watchdog easily with distros just by
> doing pkill -9 watchdog.
>
> Reported-by: Thomas Dziedzic <gostrc@gmail.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
>
> --- a/drivers/watchdog/omap_wdt.c
> +++ b/drivers/watchdog/omap_wdt.c
> @@ -189,7 +189,7 @@ static int omap_wdt_set_timeout(struct watchdog_device *wdog,
> }
>
> static const struct watchdog_info omap_wdt_info = {
> - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING,
> + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING,
> .identity = "OMAP Watchdog",
> };
>
> --- a/drivers/watchdog/retu_wdt.c
> +++ b/drivers/watchdog/retu_wdt.c
> @@ -94,7 +94,7 @@ static int retu_wdt_set_timeout(struct watchdog_device *wdog,
> }
>
> static const struct watchdog_info retu_wdt_info = {
> - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING,
> + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING,
> .identity = "Retu watchdog",
> };
>
> --- a/drivers/watchdog/twl4030_wdt.c
> +++ b/drivers/watchdog/twl4030_wdt.c
> @@ -57,7 +57,7 @@ static int twl4030_wdt_set_timeout(struct watchdog_device *wdt,
> }
>
> static const struct watchdog_info twl4030_wdt_info = {
> - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING,
> + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING,
> .identity = "TWL4030 Watchdog",
> };
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] watchdog: Fix omap watchdogs to enable the magic close bit
[not found] ` <20141014192518.GH4972-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
@ 2015-01-05 18:59 ` Tony Lindgren
[not found] ` <20150105185902.GH4081-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Tony Lindgren @ 2015-01-05 18:59 UTC (permalink / raw)
To: Wim Van Sebroeck
Cc: linux-watchdog-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA, Thomas Dziedzic
* Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> [141014 12:27]:
> This allows testing the watchdog easily with distros just by
> doing pkill -9 watchdog.
>
> Reported-by: Thomas Dziedzic <gostrc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Wim, still not seeing this applied, did you forget about this one?
Regards,
Tony
> --- a/drivers/watchdog/omap_wdt.c
> +++ b/drivers/watchdog/omap_wdt.c
> @@ -189,7 +189,7 @@ static int omap_wdt_set_timeout(struct watchdog_device *wdog,
> }
>
> static const struct watchdog_info omap_wdt_info = {
> - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING,
> + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING,
> .identity = "OMAP Watchdog",
> };
>
> --- a/drivers/watchdog/retu_wdt.c
> +++ b/drivers/watchdog/retu_wdt.c
> @@ -94,7 +94,7 @@ static int retu_wdt_set_timeout(struct watchdog_device *wdog,
> }
>
> static const struct watchdog_info retu_wdt_info = {
> - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING,
> + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING,
> .identity = "Retu watchdog",
> };
>
> --- a/drivers/watchdog/twl4030_wdt.c
> +++ b/drivers/watchdog/twl4030_wdt.c
> @@ -57,7 +57,7 @@ static int twl4030_wdt_set_timeout(struct watchdog_device *wdt,
> }
>
> static const struct watchdog_info twl4030_wdt_info = {
> - .options = WDIOF_SETTIMEOUT | WDIOF_KEEPALIVEPING,
> + .options = WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING,
> .identity = "TWL4030 Watchdog",
> };
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] watchdog: Fix omap watchdogs to enable the magic close bit
2015-02-02 23:41 ` Wim Van Sebroeck
@ 2015-02-02 23:40 ` Tony Lindgren
0 siblings, 0 replies; 7+ messages in thread
From: Tony Lindgren @ 2015-02-02 23:40 UTC (permalink / raw)
To: Wim Van Sebroeck; +Cc: linux-watchdog, linux-omap, Thomas Dziedzic
* Wim Van Sebroeck <wim@iguana.be> [150202 15:44]:
> Hi Tony,
>
> > * Tony Lindgren <tony@atomide.com> [141014 12:27]:
> > > This allows testing the watchdog easily with distros just by
> > > doing pkill -9 watchdog.
> > >
> > > Reported-by: Thomas Dziedzic <gostrc@gmail.com>
> > > Signed-off-by: Tony Lindgren <tony@atomide.com>
> >
> > Wim, still not seeing this applied, did you forget about this one?
>
> I just applied it to linux-watchdog-next.
> Didn't forgot about it, just didn't had the time yet.
OK thanks!
Tony
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] watchdog: Fix omap watchdogs to enable the magic close bit
[not found] ` <20150105185902.GH4081-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
@ 2015-02-02 23:41 ` Wim Van Sebroeck
2015-02-02 23:40 ` Tony Lindgren
0 siblings, 1 reply; 7+ messages in thread
From: Wim Van Sebroeck @ 2015-02-02 23:41 UTC (permalink / raw)
To: Tony Lindgren
Cc: linux-watchdog-u79uwXL29TY76Z2rM5mHXA,
linux-omap-u79uwXL29TY76Z2rM5mHXA, Thomas Dziedzic
Hi Tony,
> * Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> [141014 12:27]:
> > This allows testing the watchdog easily with distros just by
> > doing pkill -9 watchdog.
> >
> > Reported-by: Thomas Dziedzic <gostrc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
>
> Wim, still not seeing this applied, did you forget about this one?
I just applied it to linux-watchdog-next.
Didn't forgot about it, just didn't had the time yet.
Kind regards,
Wim.
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-02-02 23:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-14 19:25 [PATCH] watchdog: Fix omap watchdogs to enable the magic close bit Tony Lindgren
2014-10-14 20:01 ` Guenter Roeck
2014-10-14 20:09 ` Aaro Koskinen
2014-10-15 14:42 ` Felipe Balbi
[not found] ` <20141014192518.GH4972-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-01-05 18:59 ` Tony Lindgren
[not found] ` <20150105185902.GH4081-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-02-02 23:41 ` Wim Van Sebroeck
2015-02-02 23:40 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).