From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Tomasz Figa <tomasz.figa@gmail.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>,
lauraa@codeaurora.org, linux-omap@vger.kernel.org,
linus.walleij@linaro.org, santosh.shilimkar@ti.com,
tony@atomide.com, drake@endlessm.com, loeliger@gmail.com,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v6 4/7] ARM: l2c: Add support for overriding prefetch settings
Date: Tue, 28 Oct 2014 11:35:31 +0000 [thread overview]
Message-ID: <20141028113531.GZ12379@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <544E2A46.7070106@samsung.com>
On Mon, Oct 27, 2014 at 12:19:34PM +0100, Marek Szyprowski wrote:
> Hello,
>
> On 2014-10-27 12:14, Russell King - ARM Linux wrote:
>> On Mon, Oct 27, 2014 at 12:05:47PM +0100, Marek Szyprowski wrote:
>>> From: Tomasz Figa <t.figa@samsung.com>
>>>
>>> Firmware on certain boards (e.g. ODROID-U3) can leave incorrect L2C prefetch
>>> settings configured in registers leading to crashes if L2C is enabled
>>> without overriding them. This patch introduces bindings to enable
>>> prefetch settings to be specified from DT and necessary support in the
>>> driver.
>>>
>>> Signed-off-by: Tomasz Figa <t.figa@samsung.com>
>>> [mszyprow: rebased onto v3.18-rc1, added error messages when property value
>>> is missing]
>> Why? What if the boot loader has already set these up appropriately? Why
>> should we force people to list these in the DT?
>
> The error message is displayed only when user provided prefetch related
> properties without any value (empty properties). Something that Mark Rutland
> requested here: https://lkml.org/lkml/2014/9/24/426 I'm sorry if I didn't
> describe it clearly enough.
Ok.
I'd ask for one change. Please make all these messages start with
"L2C-310 OF" not "PL310 OF:". The device is described in ARM
documentation as a L2C-310 not PL310. (Also note the : is dropped
too - most of the other messages don't have the : either.)
The:
"PL310 OF: cache setting yield illegal associativity
PL310 OF: -1073346556 calculated, only 8 and 16 legal"
message could also be changed to something like:
"L2C-310 OF cache associativity %d invalid, only 8 or 16 permitted\n"
Thanks.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2014-10-28 11:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 11:05 [PATCH v6 0/7] Enable L2 cache support on Exynos4210/4x12 SoCs Marek Szyprowski
2014-10-27 11:05 ` [PATCH v6 1/7] ARM: l2c: Refactor the driver to use commit-like interface Marek Szyprowski
2014-10-27 11:05 ` [PATCH v6 2/7] ARM: l2c: Add interface to ask hypervisor to configure L2C Marek Szyprowski
2014-10-27 11:05 ` [PATCH v6 3/7] ARM: l2c: Get outer cache .write_sec callback from mach_desc only if not NULL Marek Szyprowski
2014-10-27 11:05 ` [PATCH v6 4/7] ARM: l2c: Add support for overriding prefetch settings Marek Szyprowski
2014-10-27 11:14 ` Russell King - ARM Linux
2014-10-27 11:19 ` Marek Szyprowski
2014-10-28 11:35 ` Russell King - ARM Linux [this message]
2014-10-28 11:50 ` Fabio Estevam
2014-10-27 11:05 ` [PATCH v6 5/7] ARM: EXYNOS: Add .write_sec outer cache callback for L2C-310 Marek Szyprowski
2014-10-27 11:05 ` [PATCH v6 6/7] ARM: EXYNOS: Add support for non-secure L2X0 resume Marek Szyprowski
2014-10-27 11:05 ` [PATCH v6 7/7] ARM: dts: exynos4: Add nodes for L2 cache controller Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141028113531.GZ12379@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=drake@endlessm.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lauraa@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=loeliger@gmail.com \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=santosh.shilimkar@ti.com \
--cc=tomasz.figa@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox