* [PATCH] mfd: twl4030-power: Fix regression with missing compatible flag
@ 2014-11-02 18:09 Tony Lindgren
2014-11-03 16:03 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Tony Lindgren @ 2014-11-02 18:09 UTC (permalink / raw)
To: Lee Jones
Cc: Samuel Ortiz, Dr. H. Nikolaus Schaller, linux-kernel, linux-omap
Commit e7cd1d1eb16f ("mfd: twl4030-power: Add generic reset
configuration") accidentally removed the compatible flag for
"ti,twl4030-power" that should be there as documented in the
binding.
If "ti,twl4030-power" only the poweroff configuration is done
by the driver.
Fixes: e7cd1d1eb16f ("mfd: twl4030-power: Add generic reset configuration")
Cc: stable@vger.kernel.org # v3.16+
Reported-by: "Dr. H. Nikolaus Schaller" <hns@goldelico.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
--- a/drivers/mfd/twl4030-power.c
+++ b/drivers/mfd/twl4030-power.c
@@ -831,6 +831,9 @@ static struct twl4030_power_data osc_off_idle = {
static struct of_device_id twl4030_power_of_match[] = {
{
+ .compatible = "ti,twl4030-power",
+ },
+ {
.compatible = "ti,twl4030-power-reset",
.data = &omap3_reset,
},
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mfd: twl4030-power: Fix regression with missing compatible flag
2014-11-02 18:09 [PATCH] mfd: twl4030-power: Fix regression with missing compatible flag Tony Lindgren
@ 2014-11-03 16:03 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2014-11-03 16:03 UTC (permalink / raw)
To: Tony Lindgren
Cc: Samuel Ortiz, Dr. H. Nikolaus Schaller, linux-kernel, linux-omap
On Sun, 02 Nov 2014, Tony Lindgren wrote:
> Commit e7cd1d1eb16f ("mfd: twl4030-power: Add generic reset
> configuration") accidentally removed the compatible flag for
> "ti,twl4030-power" that should be there as documented in the
> binding.
>
> If "ti,twl4030-power" only the poweroff configuration is done
> by the driver.
>
> Fixes: e7cd1d1eb16f ("mfd: twl4030-power: Add generic reset configuration")
> Cc: stable@vger.kernel.org # v3.16+
> Reported-by: "Dr. H. Nikolaus Schaller" <hns@goldelico.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Applied, thanks.
> --- a/drivers/mfd/twl4030-power.c
> +++ b/drivers/mfd/twl4030-power.c
> @@ -831,6 +831,9 @@ static struct twl4030_power_data osc_off_idle = {
>
> static struct of_device_id twl4030_power_of_match[] = {
> {
> + .compatible = "ti,twl4030-power",
> + },
> + {
> .compatible = "ti,twl4030-power-reset",
> .data = &omap3_reset,
> },
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-03 16:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-02 18:09 [PATCH] mfd: twl4030-power: Fix regression with missing compatible flag Tony Lindgren
2014-11-03 16:03 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).