linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Tony Lindgren <tony@atomide.com>
Cc: Lee Jones <lee.jones@linaro.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] mfd: twl4030-power: Fix poweroff with PM configuration enabled
Date: Fri, 7 Nov 2014 11:25:49 +0000	[thread overview]
Message-ID: <20141107112549.GA4047@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20141102180756.GH31454@atomide.com>

On Sun, Nov 02, 2014 at 10:07:56AM -0800, Tony Lindgren wrote:
> Commit e7cd1d1eb16f ("mfd: twl4030-power: Add generic reset
> configuration") enabled configuring the PM features for twl4030.
> 
> This caused poweroff command to fail on devices that have the
> BCI charger on twl4030 wired, or have power wired for VBUS.
> Instead of powering off, the device reboots. This is because
> voltage is detected on charger or VBUS with the default bits
> enabled for the power transition registers.
> 
> To fix the issue, let's just clear VBUS and CHG bits as we want
> poweroff command to keep the system powered off.
> 
> Fixes: e7cd1d1eb16f ("mfd: twl4030-power: Add generic reset configuration")
> Cc: stable@vger.kernel.org # v3.16+
> Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

This fixes the problem for me, thanks.  This needs to go into -rc as
it's a regression between booting non-DT and DT, and stands in the way
of me switching from non-DT booting on OMAP3430.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

  parent reply	other threads:[~2014-11-07 11:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-02 18:07 [PATCH] mfd: twl4030-power: Fix poweroff with PM configuration enabled Tony Lindgren
2014-11-03 15:30 ` Lee Jones
2014-11-04 13:20 ` Igor Grinberg
2014-11-04 15:42   ` Tony Lindgren
2014-11-04 17:52     ` Igor Grinberg
2014-11-04 18:04       ` Tony Lindgren
2014-11-12 15:45     ` Grazvydas Ignotas
2014-11-12 16:26       ` Tony Lindgren
2014-11-12 20:26       ` Dr. H. Nikolaus Schaller
2014-11-12 21:20         ` Tony Lindgren
2014-11-12 22:31           ` Felipe Balbi
2014-11-19  3:43             ` NeilBrown
2014-11-21 23:37               ` Tony Lindgren
2014-11-07 11:25 ` Russell King - ARM Linux [this message]
2014-11-10 12:40 ` Lee Jones
2014-11-10 17:53   ` Russell King - ARM Linux
2014-11-11 12:31     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141107112549.GA4047@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).