From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Linux USB Mailing List <linux-usb@vger.kernel.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] arm: boot: dts: am4372: enable dwc3 suspend PHY quirk
Date: Mon, 10 Nov 2014 15:11:32 -0800 [thread overview]
Message-ID: <20141110231132.GA31454@atomide.com> (raw)
In-Reply-To: <1415295366-593-2-git-send-email-balbi@ti.com>
* Felipe Balbi <balbi@ti.com> [141106 09:40]:
> Whenever Suspend PHY bit is set on AM437x devices,
> USB will not work due to Set EP Configuration command
> always failing.
>
> This was only found after a recent commit 2164a47 (usb:
> dwc3: set SUSPHY bit for all cores, which will be merged
> for v3.19) added a missing *required* step to dwc3
> initialization. Synopsys Databook requires that we enable
> Suspend PHY bit after initialization but that, unfortunately,
> breaks AM437x.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
This should be safe to queue along with the related USB
changes:
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/boot/dts/am4372.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> index 46660ff..e19068d 100644
> --- a/arch/arm/boot/dts/am4372.dtsi
> +++ b/arch/arm/boot/dts/am4372.dtsi
> @@ -817,6 +817,8 @@
> maximum-speed = "high-speed";
> dr_mode = "otg";
> status = "disabled";
> + snps,dis_u3_susphy_quirk;
> + snps,dis_u2_susphy_quirk;
> };
> };
>
> @@ -839,6 +841,8 @@
> maximum-speed = "high-speed";
> dr_mode = "otg";
> status = "disabled";
> + snps,dis_u3_susphy_quirk;
> + snps,dis_u2_susphy_quirk;
> };
> };
>
> --
> 2.1.0.GIT
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
prev parent reply other threads:[~2014-11-10 23:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 17:36 [PATCH 1/2] usb: dwc3: core: enable phy suspend quirk on non-FPGA Felipe Balbi
[not found] ` <1415295366-593-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2014-11-06 17:36 ` [PATCH 2/2] arm: boot: dts: am4372: enable dwc3 suspend PHY quirk Felipe Balbi
2014-11-10 23:11 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141110231132.GA31454@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).