From: "Pali Rohár" <pali.rohar@gmail.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
aaro.koskinen@iki.fi, freemangordon@abv.bg,
Sakari Ailus <sakari.ailus@iki.fi>
Subject: Re: N900 modem support in 3.18-rc1
Date: Fri, 14 Nov 2014 18:34:18 +0100 [thread overview]
Message-ID: <201411141834.19242@pali> (raw)
In-Reply-To: <20141114172008.GB12250@earth.universe>
[-- Attachment #1: Type: Text/Plain, Size: 1403 bytes --]
On Friday 14 November 2014 18:20:09 Sebastian Reichel wrote:
> Hi,
>
> On Fri, Nov 14, 2014 at 09:04:23AM +0200, Ivaylo Dimitrov
wrote:
> > [...]
> > https://gitorious.org/linux-n900/freemangordons-linux-n900/c
> > ommits/30e9a5c498a89cea4c29523f69e436bf0af3c631
> >
> > commits 89ce13b, b81d80d, ec4d0dc, 91256e2 and 8022a6d -
> > e29f558 (no idea why gitorious shows those mixed with SGX
> > stuff, on my local tree it is contiguous patch series)
> >
> > didn't test against the current upstream, but I see no
> > reason why those should not apply, build and run.
>
> The patch looks ok. It does not cleanup the cmt-speech driver
> for mainline usage, but it should work. Before adding this
> driver to the mainline kernel there should be open source
> userspace support anyway.
>
> Btw. I am aware that this would break existing pulse audio
> stuff, but wouldn't it make sense to export a V4L2 device
> instead of the custom /dev/cmt_speech ABI?
>
It is not good idea to break existing applications even if they
are closed... And there are some open source meego/nemo
pulseaudio modules which using cmt speech (but audio quality is
worse).
Anyway what is /dev/cmt_speech doing? If it exports gsm voice
call data, should not it have alsa snd interface?
V4L2 interface is not for video/camera/capture/tv cards?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2014-11-14 17:34 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 20:51 N900 modem support in 3.18-rc1 Pavel Machek
2014-11-05 1:11 ` Sebastian Reichel
2014-11-05 20:31 ` Pavel Machek
2014-11-05 20:37 ` Pali Rohár
2014-11-05 20:39 ` Pavel Machek
2014-11-05 21:06 ` Pali Rohár
2014-11-05 22:03 ` Pavel Machek
2014-11-05 23:45 ` Sebastian Reichel
2014-11-06 12:47 ` Pavel Machek
2014-11-06 18:03 ` Sebastian Reichel
2014-11-06 22:50 ` Pavel Machek
2014-11-06 23:01 ` Pali Rohár
2014-11-07 7:04 ` Ivaylo Dimitrov
2014-11-13 16:24 ` Pavel Machek
2014-11-14 7:04 ` Ivaylo Dimitrov
2014-11-14 17:20 ` Sebastian Reichel
2014-11-14 17:34 ` Pali Rohár [this message]
2014-11-14 22:05 ` Sebastian Reichel
2014-11-14 19:54 ` Ivaylo Dimitrov
2014-11-14 21:14 ` Pavel Machek
2014-11-14 21:57 ` Sebastian Reichel
2014-11-20 10:13 ` voice calls on N900 working (off-line) was " Pavel Machek
2014-11-20 10:17 ` Pavel Machek
2014-11-25 23:21 ` GPRS data on N900 working " Pavel Machek
2015-02-11 18:32 ` Voice calls working on N900 (*) (was Re: N900 modem support in 3.18-rc1) Pavel Machek
2015-02-11 20:56 ` Pavel Machek
2014-11-13 16:21 ` N900 modem support in 3.18-rc1 Pavel Machek
2014-11-13 17:45 ` Tony Lindgren
2014-11-13 18:18 ` Aaro Koskinen
2014-11-16 10:12 ` Pavel Machek
2014-11-16 12:29 ` Robert Jarzmik
2014-11-18 7:42 ` Pavel Machek
2014-11-19 19:01 ` Robert Jarzmik
2014-11-14 7:37 ` Pavel Machek
2014-11-14 16:53 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201411141834.19242@pali \
--to=pali.rohar@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=freemangordon@abv.bg \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sakari.ailus@iki.fi \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).