From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
Fabio Baltieri <fabio.baltieri@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 4/8] usb: musb: Change to use new IO access
Date: Mon, 24 Nov 2014 11:26:09 -0800 [thread overview]
Message-ID: <20141124192609.GF2757@atomide.com> (raw)
In-Reply-To: <20141124191202.GH25712@saruman>
* Felipe Balbi <balbi@ti.com> [141124 11:13]:
> On Mon, Nov 24, 2014 at 11:05:02AM -0800, Tony Lindgren wrote:
> > @@ -312,10 +345,40 @@ void musb_read_fifo(struct musb_hw_ep *hw_ep, u16 len, u8 *dst)
> > ioread8_rep(fifo, dst, len);
> > }
> > }
> > -#endif
> >
> > -#endif /* normal PIO */
> > +/*
> > + * Old style IO functions
> > + */
> > +u8 (*musb_readb)(const void __iomem *addr, unsigned offset);
> > +EXPORT_SYMBOL(musb_readb);
> > +
> > +void (*musb_writeb)(void __iomem *addr, unsigned offset, u8 data);
> > +EXPORT_SYMBOL(musb_writeb);
> >
> > +u16 (*musb_readw)(const void __iomem *addr, unsigned offset);
> > +EXPORT_SYMBOL(musb_readw);
> > +
> > +void (*musb_writew)(void __iomem *addr, unsigned offset, u16 data);
> > +EXPORT_SYMBOL(musb_writew);
> > +
> > +u32 (*musb_readl)(const void __iomem *addr, unsigned offset);
> > +EXPORT_SYMBOL(musb_readl);
> > +
> > +void (*musb_writel)(void __iomem *addr, unsigned offset, u32 data);
> > +EXPORT_SYMBOL(musb_writel);
>
> let's make all these _GPL()
Sure.
Tony
next prev parent reply other threads:[~2014-11-24 19:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 19:04 [PATCH 0/8] Allow multiple MUSB glue layers to be built in Tony Lindgren
2014-11-24 19:05 ` [PATCH 2/8] usb: musb: Populate new IO functions for tusb6010 Tony Lindgren
2014-11-24 19:05 ` [PATCH 3/8] usb: musb: Populate new IO functions for blackfin Tony Lindgren
[not found] ` <1416855906-13931-1-git-send-email-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-11-24 19:04 ` [PATCH 1/8] usb: musb: Add function pointers for IO access functions Tony Lindgren
2014-11-24 19:05 ` [PATCH 4/8] usb: musb: Change to use new IO access Tony Lindgren
2014-11-24 19:12 ` Felipe Balbi
2014-11-24 19:26 ` Tony Lindgren [this message]
[not found] ` <1416855906-13931-5-git-send-email-tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2014-11-25 9:46 ` Linus Walleij
2014-11-24 19:05 ` [PATCH 5/8] usb: musb: Change end point selection " Tony Lindgren
2014-11-24 23:38 ` Apelete Seketeli
2014-11-24 23:52 ` Tony Lindgren
2014-11-25 15:02 ` Lars-Peter Clausen
2014-11-28 13:50 ` Linus Walleij
2014-11-24 19:05 ` [PATCH 6/8] usb: musb: Pass fifo_mode in platform data Tony Lindgren
2014-11-24 23:40 ` Apelete Seketeli
2014-11-28 13:40 ` Linus Walleij
2014-11-24 19:05 ` [PATCH 7/8] usb: musb: Allow multiple glue layers to be built in Tony Lindgren
2014-11-24 19:05 ` [PATCH 8/8] usb: musb: Use IS_ENABLED for tusb6010 Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141124192609.GF2757@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=fabio.baltieri@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).