From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Sebastian Reichel <sre@kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning
Date: Thu, 4 Dec 2014 08:39:31 -0800 [thread overview]
Message-ID: <20141204163930.GF2817@atomide.com> (raw)
In-Reply-To: <20141204154835.GH18045@saruman>
* Felipe Balbi <balbi@ti.com> [141204 07:50]:
> Hi,
>
> On Thu, Dec 04, 2014 at 04:41:13PM +0100, Arnd Bergmann wrote:
> > On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote:
> > > On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote:
> > > > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update
> > > > si4713 platform data) updated board-rx51-peripherals.c
> > > > so that si4713 could be easily used on DT boot, but
> > > > it ended up introducing a build warning whenever
> > > > si4713 isn't enabled.
> > > >
> > > > This patches fixes that warning:
> > > >
> > > > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: \
> > > > ‘rx51_si4713_platform_data’ defined but not used [-Wunused-variable]
> > > > static struct si4713_platform_data rx51_si4713_platform_data = {
> > > >
> > > > Cc: Sebastian Reichel <sre@kernel.org>
> > > > Cc: Tony Lindgren <tony@atomide.com>
> > > > Cc: Hans Verkuil <hans.verkuil@cisco.com>
> > > > Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
> > > > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > >
> > > a gentle reminder on this one.
> > >
> >
> > Let me add my
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> >
> > You didn't say who you expect to pick up the patch. I assume Mauro
>
> patch author now decides who takes the patch ? That's new :-)
>
> > should take it because he took the patch that caused the problem,
> > but he might not be aware that he should look at this now.
>
> He is in Cc, let's ask him :-)
Best that this one goes in along with the other si4713 patches
to avoid dependencies between trees:
Acked-by: Tony Lindgren <tony@atomide.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-12-04 16:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 20:27 [PATCH] arm: omap2: rx51-peripherals: fix build warning Felipe Balbi
2014-11-26 21:56 ` Sebastian Reichel
2014-11-27 7:41 ` Hans Verkuil
2014-12-04 15:24 ` Felipe Balbi
2014-12-04 15:41 ` Arnd Bergmann
2014-12-04 15:48 ` Felipe Balbi
2014-12-04 16:39 ` Tony Lindgren [this message]
2014-12-04 17:00 ` Mauro Carvalho Chehab
2014-12-04 17:03 ` Felipe Balbi
2014-12-04 17:12 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141204163930.GF2817@atomide.com \
--to=tony@atomide.com \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=hans.verkuil@cisco.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).