From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] arm: omap2: rx51-peripherals: fix build warning Date: Thu, 4 Dec 2014 08:39:31 -0800 Message-ID: <20141204163930.GF2817@atomide.com> References: <1417033655-32332-1-git-send-email-balbi@ti.com> <20141204152411.GF18045@saruman> <3261416.DL88JFJXUF@wuerfel> <20141204154835.GH18045@saruman> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:11622 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932699AbaLDQlr (ORCPT ); Thu, 4 Dec 2014 11:41:47 -0500 Content-Disposition: inline In-Reply-To: <20141204154835.GH18045@saruman> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Balbi Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Mauro Carvalho Chehab , Sebastian Reichel , Hans Verkuil , Linux OMAP Mailing List * Felipe Balbi [141204 07:50]: > Hi, >=20 > On Thu, Dec 04, 2014 at 04:41:13PM +0100, Arnd Bergmann wrote: > > On Thursday 04 December 2014 09:24:11 Felipe Balbi wrote: > > > On Wed, Nov 26, 2014 at 02:27:35PM -0600, Felipe Balbi wrote: > > > > commit 68a3c04 ([media] ARM: OMAP2: RX-51: update > > > > si4713 platform data) updated board-rx51-peripherals.c > > > > so that si4713 could be easily used on DT boot, but > > > > it ended up introducing a build warning whenever > > > > si4713 isn't enabled. > > > >=20 > > > > This patches fixes that warning: > > > >=20 > > > > arch/arm/mach-omap2/board-rx51-peripherals.c:1000:36: warning: = \ > > > > =E2=80=98rx51_si4713_platform_data=E2=80=99 defined but not us= ed [-Wunused-variable] > > > > static struct si4713_platform_data rx51_si4713_platform_data =3D= { > > > >=20 > > > > Cc: Sebastian Reichel > > > > Cc: Tony Lindgren > > > > Cc: Hans Verkuil > > > > Cc: Mauro Carvalho Chehab > > > > Signed-off-by: Felipe Balbi > > >=20 > > > a gentle reminder on this one. > > >=20 > >=20 > > Let me add my > >=20 > > Acked-by: Arnd Bergmann > >=20 > > You didn't say who you expect to pick up the patch. I assume Mauro >=20 > patch author now decides who takes the patch ? That's new :-) >=20 > > should take it because he took the patch that caused the problem, > > but he might not be aware that he should look at this now. >=20 > He is in Cc, let's ask him :-) Best that this one goes in along with the other si4713 patches to avoid dependencies between trees: Acked-by: Tony Lindgren -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html