From: Pavel Machek <pavel@ucw.cz>
To: Nishanth Menon <nm@ti.com>
Cc: linux-omap@vger.kernel.org, edubezval@gmail.com,
rui.zhang@intel.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] cleanup ti-soc-thermal
Date: Sat, 3 Jan 2015 20:02:18 +0100 [thread overview]
Message-ID: <20150103190218.GA6814@amd> (raw)
In-Reply-To: <54A83B80.1020508@ti.com>
On Sat 2015-01-03 12:57:04, Nishanth Menon wrote:
> On 01/03/2015 12:51 PM, Pavel Machek wrote:
> >On Sat 2015-01-03 11:48:04, Nishanth Menon wrote:
> >>On 12:19-20150103, Pavel Machek wrote:
> >>>Simplify code by removing goto's where they point to simple return.
> >>>
> >>>Avoid confusing |= on error values.
> >>
> >>Please split these up into chunks of related changes. there is white
> >>space and quiet a few other changes all mixed in.
> >
> >Do you believe that the patch is too big to be understood? I don't
> >think it is.
> >
> >It is four screens, and it is pretty obvious it does not change any
> >code.
>
> It basic patch generation stuff - where you are being nice to the reviewer.
> When you are doing functional changes, at least drop out or at the very
> least mention that there are white space changes in your patch
> submission.
Original submission said:
# Correct whitespace.
Some maintainers actually hate separate whitespace changes; talk to Al
Viro some day.
> I dont care too much to review stuff where I have to look at multiple
> changes in a single patch - trivial or not. Sorry.. just a waste of my time.
If 4 screens of trivial changes are too much for you, don't review
trivial patches, then. It is not your job.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-01-03 19:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150103111904.GA11545@amd>
[not found] ` <20150103174804.GA20341@kahuna>
2015-01-03 18:51 ` [PATCH] cleanup ti-soc-thermal Pavel Machek
2015-01-03 18:57 ` Nishanth Menon
2015-01-03 19:02 ` Pavel Machek [this message]
2015-01-18 20:17 ` [PATCHv2] " Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150103190218.GA6814@amd \
--to=pavel@ucw.cz \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).