* [PATCH] hsi: nokia-modem: fix uninitialized device pointer
@ 2015-01-04 17:34 Aaro Koskinen
2015-01-04 19:23 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Aaro Koskinen @ 2015-01-04 17:34 UTC (permalink / raw)
To: Sebastian Reichel, linux-omap, linux-kernel; +Cc: Aaro Koskinen
modem->device was never initialized. This resulted in logs such as:
[ 241.386322] (NULL device *): CMT rst line change detected
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
---
drivers/hsi/clients/nokia-modem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hsi/clients/nokia-modem.c b/drivers/hsi/clients/nokia-modem.c
index f0c2145..eb4dc63 100644
--- a/drivers/hsi/clients/nokia-modem.c
+++ b/drivers/hsi/clients/nokia-modem.c
@@ -162,6 +162,7 @@ static int nokia_modem_probe(struct device *dev)
return -ENOMEM;
}
dev_set_drvdata(dev, modem);
+ modem->device = dev;
irq = irq_of_parse_and_map(np, 0);
if (!irq) {
--
2.2.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hsi: nokia-modem: fix uninitialized device pointer
2015-01-04 17:34 [PATCH] hsi: nokia-modem: fix uninitialized device pointer Aaro Koskinen
@ 2015-01-04 19:23 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2015-01-04 19:23 UTC (permalink / raw)
To: Aaro Koskinen; +Cc: linux-omap, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 377 bytes --]
Hi Aaro,
On Sun, Jan 04, 2015 at 07:34:13PM +0200, Aaro Koskinen wrote:
> modem->device was never initialized. This resulted in logs such as:
> [ 241.386322] (NULL device *): CMT rst line change detected
Thanks, applied to for-next:
https://git.kernel.org/cgit/linux/kernel/git/sre/linux-hsi.git/commit/?h=for-next&id=67e9a2ce6e070b1e5db2dfe9c61890fc30ae954d
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-04 19:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-04 17:34 [PATCH] hsi: nokia-modem: fix uninitialized device pointer Aaro Koskinen
2015-01-04 19:23 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).