From: Pavel Machek <pavel@ucw.cz>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, "Kevin Hilman" <khilman@kernel.org>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Sebastian Reichel" <sre@kernel.org>,
"Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [PATCH] ARM: dts: Revert disabling of smc91x for n900
Date: Tue, 6 Jan 2015 09:00:26 +0100 [thread overview]
Message-ID: <20150106080025.GA6752@amd> (raw)
In-Reply-To: <20150105230228.GO4081@atomide.com>
On Mon 2015-01-05 15:02:29, Tony Lindgren wrote:
> Revert "ARM: dts: Disable smc91x on n900 until bootloader
> dependency is removed". We've now fixed the issues that
> caused problems with uninitialized hardware depending on
> the bootloader version. Mostly things got fixed with
> the following commits:
>
> 9a894953a97b ("ARM: dts: Fix bootloader version dependencies by muxing n900 smc91x pins")
> 7d2911c43815 ("net: smc91x: Fix gpios for device tree based booting")
>
> Note that this only affects the early development boards
> with Ethernet that we still have in a few automated boot
> test systems.
>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Normally, the early development boards should have separate dts file
(then include common parts), no?
Could you at least add a note to the dts file what is it? Because I
always thought it is a bug.
[Plus of course, obviouse question is: where can I get one of those
boards? :-)]
Pavel
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -702,9 +702,6 @@
>
> ethernet@gpmc {
> compatible = "smsc,lan91c94";
> -
> - status = "disabled";
> -
> interrupt-parent = <&gpio2>;
> interrupts = <22 IRQ_TYPE_LEVEL_HIGH>; /* gpio54 */
> reg = <1 0x300 0xf>; /* 16 byte IO range at offset 0x300 */
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-01-06 8:00 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 23:02 [PATCH] ARM: dts: Revert disabling of smc91x for n900 Tony Lindgren
2015-01-05 23:09 ` Pali Rohár
2015-01-05 23:10 ` Tony Lindgren
2015-01-06 15:03 ` Sebastian Reichel
2015-01-06 15:23 ` Pali Rohár
2015-01-06 8:00 ` Pavel Machek [this message]
2015-01-06 16:59 ` Tony Lindgren
2015-01-06 19:44 ` Aaro Koskinen
2015-01-06 19:54 ` Tony Lindgren
2015-01-06 20:17 ` Tony Lindgren
2015-01-06 20:34 ` Pali Rohár
2015-01-06 21:24 ` Tony Lindgren
2015-01-06 20:42 ` Pavel Machek
2015-01-06 21:56 ` Aaro Koskinen
2015-01-06 22:04 ` Tony Lindgren
2015-01-06 19:59 ` Pali Rohár
2015-01-07 9:57 ` Pavel Machek
2015-01-07 15:44 ` Nishanth Menon
2015-01-07 16:40 ` Tony Lindgren
2015-01-07 20:09 ` Pavel Machek
2015-01-07 21:25 ` Pavel Machek
2015-01-08 9:01 ` Pali Rohár
2015-01-08 18:54 ` Tony Lindgren
2015-01-07 20:00 ` Pavel Machek
2015-01-06 17:38 ` Kevin Hilman
2015-02-18 15:19 ` Pali Rohár
2015-02-18 16:33 ` Tony Lindgren
2015-02-18 19:04 ` Pali Rohár
2015-02-18 22:42 ` Tony Lindgren
2015-02-18 22:52 ` Pali Rohár
2015-02-19 4:50 ` Tony Lindgren
2015-02-19 10:59 ` Pali Rohár
2015-02-19 16:47 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106080025.GA6752@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=khilman@kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).