From: Tony Lindgren <tony@atomide.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: "Pavel Machek" <pavel@ucw.cz>,
linux-omap@vger.kernel.org, "Kevin Hilman" <khilman@kernel.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [PATCH] ARM: dts: Revert disabling of smc91x for n900
Date: Tue, 6 Jan 2015 11:54:55 -0800 [thread overview]
Message-ID: <20150106195454.GW4081@atomide.com> (raw)
In-Reply-To: <20150106194443.GH30544@fuloong-minipc.musicnaut.iki.fi>
* Aaro Koskinen <aaro.koskinen@iki.fi> [150106 11:47]:
> Hi,
>
> On Tue, Jan 06, 2015 at 08:59:03AM -0800, Tony Lindgren wrote:
> > * Pavel Machek <pavel@ucw.cz> [150106 00:03]:
> > > On Mon 2015-01-05 15:02:29, Tony Lindgren wrote:
> > > > Revert "ARM: dts: Disable smc91x on n900 until bootloader
> > > > dependency is removed". We've now fixed the issues that
> > > > caused problems with uninitialized hardware depending on
> > > > the bootloader version. Mostly things got fixed with
> > > > the following commits:
> > > >
> > > > 9a894953a97b ("ARM: dts: Fix bootloader version dependencies by muxing n900 smc91x pins")
> > > > 7d2911c43815 ("net: smc91x: Fix gpios for device tree based booting")
> > > >
> > > > Note that this only affects the early development boards
> > > > with Ethernet that we still have in a few automated boot
> > > > test systems.
> > > >
> > > > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > >
> > > Normally, the early development boards should have separate dts file
> > > (then include common parts), no?
> >
> > In this case it won't matter. The GPMC hardware is there, the probe
> > just fails if no smsc91x is found.
> >
> > > Could you at least add a note to the dts file what is it? Because I
> > > always thought it is a bug.
> >
> > Sure, updated patch below. Can somebody please test boot it on
> > a production n900 too to make sure it no longer causes issues?
>
> Seems to work fine with normal n900.
>
> Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
OK good to hear, thanks for testing.
> I also tested with a development board, eth0 seemed to appear,
> but couldn't configure the MAC address with busybox ifconfig.
> How should it be done, I guess the interface does not have any
> MAC by default?
You need to write the eeprom with ethtool from Linux, something
like this:
Run u-boot/tools/gen_eth_addr to generate a random local mac,
then swap the bytes for it for big endian. Enter them into a
file with hexedit in big endian order. Then just do:
# cat mac | ethtool -E eth0 offset 0x40 length 6
Then ethtool -e eth0 should show you the configuration.
Regards,
Tony
next prev parent reply other threads:[~2015-01-06 19:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 23:02 [PATCH] ARM: dts: Revert disabling of smc91x for n900 Tony Lindgren
2015-01-05 23:09 ` Pali Rohár
2015-01-05 23:10 ` Tony Lindgren
2015-01-06 15:03 ` Sebastian Reichel
2015-01-06 15:23 ` Pali Rohár
2015-01-06 8:00 ` Pavel Machek
2015-01-06 16:59 ` Tony Lindgren
2015-01-06 19:44 ` Aaro Koskinen
2015-01-06 19:54 ` Tony Lindgren [this message]
2015-01-06 20:17 ` Tony Lindgren
2015-01-06 20:34 ` Pali Rohár
2015-01-06 21:24 ` Tony Lindgren
2015-01-06 20:42 ` Pavel Machek
2015-01-06 21:56 ` Aaro Koskinen
2015-01-06 22:04 ` Tony Lindgren
2015-01-06 19:59 ` Pali Rohár
2015-01-07 9:57 ` Pavel Machek
2015-01-07 15:44 ` Nishanth Menon
2015-01-07 16:40 ` Tony Lindgren
2015-01-07 20:09 ` Pavel Machek
2015-01-07 21:25 ` Pavel Machek
2015-01-08 9:01 ` Pali Rohár
2015-01-08 18:54 ` Tony Lindgren
2015-01-07 20:00 ` Pavel Machek
2015-01-06 17:38 ` Kevin Hilman
2015-02-18 15:19 ` Pali Rohár
2015-02-18 16:33 ` Tony Lindgren
2015-02-18 19:04 ` Pali Rohár
2015-02-18 22:42 ` Tony Lindgren
2015-02-18 22:52 ` Pali Rohár
2015-02-19 4:50 ` Tony Lindgren
2015-02-19 10:59 ` Pali Rohár
2015-02-19 16:47 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106195454.GW4081@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=khilman@kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).