From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: dts: Revert disabling of smc91x for n900 Date: Tue, 6 Jan 2015 11:54:55 -0800 Message-ID: <20150106195454.GW4081@atomide.com> References: <20150105230228.GO4081@atomide.com> <20150106080025.GA6752@amd> <20150106165903.GF4025@atomide.com> <20150106194443.GH30544@fuloong-minipc.musicnaut.iki.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:43607 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751939AbbAFT6p (ORCPT ); Tue, 6 Jan 2015 14:58:45 -0500 Content-Disposition: inline In-Reply-To: <20150106194443.GH30544@fuloong-minipc.musicnaut.iki.fi> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Aaro Koskinen Cc: Pavel Machek , linux-omap@vger.kernel.org, Kevin Hilman , Sebastian Reichel , Pali =?utf-8?B?Um9ow6Fy?= * Aaro Koskinen [150106 11:47]: > Hi, > > On Tue, Jan 06, 2015 at 08:59:03AM -0800, Tony Lindgren wrote: > > * Pavel Machek [150106 00:03]: > > > On Mon 2015-01-05 15:02:29, Tony Lindgren wrote: > > > > Revert "ARM: dts: Disable smc91x on n900 until bootloader > > > > dependency is removed". We've now fixed the issues that > > > > caused problems with uninitialized hardware depending on > > > > the bootloader version. Mostly things got fixed with > > > > the following commits: > > > > > > > > 9a894953a97b ("ARM: dts: Fix bootloader version dependencies by muxing n900 smc91x pins") > > > > 7d2911c43815 ("net: smc91x: Fix gpios for device tree based booting") > > > > > > > > Note that this only affects the early development boards > > > > with Ethernet that we still have in a few automated boot > > > > test systems. > > > > > > > > Signed-off-by: Tony Lindgren > > > > > > Normally, the early development boards should have separate dts file > > > (then include common parts), no? > > > > In this case it won't matter. The GPMC hardware is there, the probe > > just fails if no smsc91x is found. > > > > > Could you at least add a note to the dts file what is it? Because I > > > always thought it is a bug. > > > > Sure, updated patch below. Can somebody please test boot it on > > a production n900 too to make sure it no longer causes issues? > > Seems to work fine with normal n900. > > Tested-by: Aaro Koskinen OK good to hear, thanks for testing. > I also tested with a development board, eth0 seemed to appear, > but couldn't configure the MAC address with busybox ifconfig. > How should it be done, I guess the interface does not have any > MAC by default? You need to write the eeprom with ethtool from Linux, something like this: Run u-boot/tools/gen_eth_addr to generate a random local mac, then swap the bytes for it for big endian. Enter them into a file with hexedit in big endian order. Then just do: # cat mac | ethtool -E eth0 offset 0x40 length 6 Then ethtool -e eth0 should show you the configuration. Regards, Tony