linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/6] arm: boot: dts: am437x-sk: DTS pinmux fixes
@ 2014-12-04 17:01 Felipe Balbi
  2014-12-04 17:01 ` [PATCH 1/6] arm: boot: dts: am437x-sk: remove internal pulls from QSPI Felipe Balbi
                   ` (6 more replies)
  0 siblings, 7 replies; 9+ messages in thread
From: Felipe Balbi @ 2014-12-04 17:01 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Linux OMAP Mailing List, Linux ARM Kernel Mailing List,
	Felipe Balbi

Here's a small series of non-critical fixes and improvements
for AM437x Starter Kit DTS.

Basically I'm removing unnecessary pulls and adding explicit
pinmux for a couple interfaces which were missing.

All patches tested on top of commit 1ca7c60 (Add linux-next
specific files for 20141204). Boot logs will be attached as
a reply here.

Felipe Balbi (6):
  arm: boot: dts: am437x-sk: remove internal pulls from QSPI
  arm: boot: dts: am437x-sk: add explicit MMC0 pinmux
  arm: boot: dts: am437x-sk: remove ethernet pulls
  arm: boot: dts: am437x-sk: add explicit pinmux for both USB instances
  arm: boot: dts: am437x-sk: remove internal i2c pullups
  arm: boot: dts: am437x-sk: remove DSS pulls

 arch/arm/boot/dts/am437x-sk-evm.dts | 150 +++++++++++++++++++++---------------
 1 file changed, 86 insertions(+), 64 deletions(-)

-- 
2.1.0.GIT


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 1/6] arm: boot: dts: am437x-sk: remove internal pulls from QSPI
  2014-12-04 17:01 [PATCH 0/6] arm: boot: dts: am437x-sk: DTS pinmux fixes Felipe Balbi
@ 2014-12-04 17:01 ` Felipe Balbi
  2014-12-04 17:01 ` [PATCH 2/6] arm: boot: dts: am437x-sk: add explicit MMC0 pinmux Felipe Balbi
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Felipe Balbi @ 2014-12-04 17:01 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Linux OMAP Mailing List, Linux ARM Kernel Mailing List,
	Felipe Balbi

QSPI doesn't need any pullups of any sort,
let's remove them.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 arch/arm/boot/dts/am437x-sk-evm.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts
index 0eceb8a..d0ce2d4 100644
--- a/arch/arm/boot/dts/am437x-sk-evm.dts
+++ b/arch/arm/boot/dts/am437x-sk-evm.dts
@@ -300,12 +300,12 @@
 
 	qspi_pins: qspi_pins {
 		pinctrl-single,pins = <
-			0x7c (PIN_OUTPUT_PULLUP | MUX_MODE3)	/* gpmc_csn0.qspi_csn */
-			0x88 (PIN_OUTPUT | MUX_MODE2)		/* gpmc_csn3.qspi_clk */
-			0x90 (PIN_INPUT_PULLUP | MUX_MODE3)	/* gpmc_advn_ale.qspi_d0 */
-			0x94 (PIN_INPUT_PULLUP | MUX_MODE3)	/* gpmc_oen_ren.qspi_d1 */
-			0x98 (PIN_INPUT_PULLUP | MUX_MODE3)	/* gpmc_wen.qspi_d2 */
-			0x9c (PIN_INPUT_PULLUP | MUX_MODE3)	/* gpmc_be0n_cle.qspi_d3 */
+			0x7c (PIN_OUTPUT | MUX_MODE3)	/* gpmc_csn0.qspi_csn */
+			0x88 (PIN_OUTPUT | MUX_MODE2)	/* gpmc_csn3.qspi_clk */
+			0x90 (PIN_INPUT | MUX_MODE3)	/* gpmc_advn_ale.qspi_d0 */
+			0x94 (PIN_INPUT | MUX_MODE3)	/* gpmc_oen_ren.qspi_d1 */
+			0x98 (PIN_INPUT | MUX_MODE3)	/* gpmc_wen.qspi_d2 */
+			0x9c (PIN_INPUT | MUX_MODE3)	/* gpmc_be0n_cle.qspi_d3 */
 		>;
 	};
 
-- 
2.1.0.GIT


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/6] arm: boot: dts: am437x-sk: add explicit MMC0 pinmux
  2014-12-04 17:01 [PATCH 0/6] arm: boot: dts: am437x-sk: DTS pinmux fixes Felipe Balbi
  2014-12-04 17:01 ` [PATCH 1/6] arm: boot: dts: am437x-sk: remove internal pulls from QSPI Felipe Balbi
@ 2014-12-04 17:01 ` Felipe Balbi
  2014-12-04 17:01 ` [PATCH 3/6] arm: boot: dts: am437x-sk: remove ethernet pulls Felipe Balbi
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Felipe Balbi @ 2014-12-04 17:01 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Linux OMAP Mailing List, Linux ARM Kernel Mailing List,
	Felipe Balbi

By don't relying on implicit MMC0 pulldown we
make sure that pins are marked busy and even
if we have a broken bootloader, MMC0 will
remain functional.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 arch/arm/boot/dts/am437x-sk-evm.dts | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts
index d0ce2d4..5d872f6 100644
--- a/arch/arm/boot/dts/am437x-sk-evm.dts
+++ b/arch/arm/boot/dts/am437x-sk-evm.dts
@@ -167,6 +167,12 @@
 
 	mmc1_pins: pinmux_mmc1_pins {
 		pinctrl-single,pins = <
+			0x0f0 (PIN_INPUT | MUX_MODE0) /* mmc0_dat3.mmc0_dat3 */
+			0x0f4 (PIN_INPUT | MUX_MODE0) /* mmc0_dat2.mmc0_dat2 */
+			0x0f8 (PIN_INPUT | MUX_MODE0) /* mmc0_dat1.mmc0_dat1 */
+			0x0fc (PIN_INPUT | MUX_MODE0) /* mmc0_dat0.mmc0_dat0 */
+			0x100 (PIN_INPUT | MUX_MODE0) /* mmc0_clk.mmc0_clk */
+			0x104 (PIN_INPUT | MUX_MODE0) /* mmc0_cmd.mmc0_cmd */
 			0x160 (PIN_INPUT | MUX_MODE7) /* spi0_cs1.gpio0_6 */
 		>;
 	};
-- 
2.1.0.GIT


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 3/6] arm: boot: dts: am437x-sk: remove ethernet pulls
  2014-12-04 17:01 [PATCH 0/6] arm: boot: dts: am437x-sk: DTS pinmux fixes Felipe Balbi
  2014-12-04 17:01 ` [PATCH 1/6] arm: boot: dts: am437x-sk: remove internal pulls from QSPI Felipe Balbi
  2014-12-04 17:01 ` [PATCH 2/6] arm: boot: dts: am437x-sk: add explicit MMC0 pinmux Felipe Balbi
@ 2014-12-04 17:01 ` Felipe Balbi
  2014-12-04 17:01 ` [PATCH 4/6] arm: boot: dts: am437x-sk: add explicit pinmux for both USB instances Felipe Balbi
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Felipe Balbi @ 2014-12-04 17:01 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Linux OMAP Mailing List, Linux ARM Kernel Mailing List,
	Felipe Balbi

AM437x Starter Kit already has discrete pulls
where they are necessary. It's safe (and actually
better) to remove internal pulls.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 arch/arm/boot/dts/am437x-sk-evm.dts | 52 ++++++++++++++++++-------------------
 1 file changed, 26 insertions(+), 26 deletions(-)

diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts
index 5d872f6..68b9529 100644
--- a/arch/arm/boot/dts/am437x-sk-evm.dts
+++ b/arch/arm/boot/dts/am437x-sk-evm.dts
@@ -193,32 +193,32 @@
 	cpsw_default: cpsw_default {
 		pinctrl-single,pins = <
 			/* Slave 1 */
-			0x12c (PIN_OUTPUT_PULLDOWN | MUX_MODE2)	/* mii1_txclk.rmii1_tclk */
-			0x114 (PIN_OUTPUT_PULLDOWN | MUX_MODE2)	/* mii1_txen.rgmii1_tctl */
-			0x128 (PIN_OUTPUT_PULLDOWN | MUX_MODE2)	/* mii1_txd0.rgmii1_td0 */
-			0x124 (PIN_OUTPUT_PULLDOWN | MUX_MODE2)	/* mii1_txd1.rgmii1_td1 */
-			0x120 (PIN_OUTPUT_PULLDOWN | MUX_MODE2)	/* mii1_txd0.rgmii1_td2 */
-			0x11c (PIN_OUTPUT_PULLDOWN | MUX_MODE2)	/* mii1_txd1.rgmii1_td3 */
-			0x130 (PIN_INPUT_PULLDOWN | MUX_MODE2)	/* mii1_rxclk.rmii1_rclk */
-			0x118 (PIN_INPUT_PULLDOWN | MUX_MODE2)	/* mii1_rxdv.rgmii1_rctl */
-			0x140 (PIN_INPUT_PULLDOWN | MUX_MODE2)	/* mii1_rxd0.rgmii1_rd0 */
-			0x13c (PIN_INPUT_PULLDOWN | MUX_MODE2)	/* mii1_rxd1.rgmii1_rd1 */
-			0x138 (PIN_INPUT_PULLDOWN | MUX_MODE2)	/* mii1_rxd0.rgmii1_rd2 */
-			0x134 (PIN_INPUT_PULLDOWN | MUX_MODE2)	/* mii1_rxd1.rgmii1_rd3 */
+			0x12c (PIN_OUTPUT | MUX_MODE2)	/* mii1_txclk.rmii1_tclk */
+			0x114 (PIN_OUTPUT | MUX_MODE2)	/* mii1_txen.rgmii1_tctl */
+			0x128 (PIN_OUTPUT | MUX_MODE2)	/* mii1_txd0.rgmii1_td0 */
+			0x124 (PIN_OUTPUT | MUX_MODE2)	/* mii1_txd1.rgmii1_td1 */
+			0x120 (PIN_OUTPUT | MUX_MODE2)	/* mii1_txd0.rgmii1_td2 */
+			0x11c (PIN_OUTPUT | MUX_MODE2)	/* mii1_txd1.rgmii1_td3 */
+			0x130 (PIN_INPUT | MUX_MODE2)	/* mii1_rxclk.rmii1_rclk */
+			0x118 (PIN_INPUT | MUX_MODE2)	/* mii1_rxdv.rgmii1_rctl */
+			0x140 (PIN_INPUT | MUX_MODE2)	/* mii1_rxd0.rgmii1_rd0 */
+			0x13c (PIN_INPUT | MUX_MODE2)	/* mii1_rxd1.rgmii1_rd1 */
+			0x138 (PIN_INPUT | MUX_MODE2)	/* mii1_rxd0.rgmii1_rd2 */
+			0x134 (PIN_INPUT | MUX_MODE2)	/* mii1_rxd1.rgmii1_rd3 */
 
 			/* Slave 2 */
-			0x58 (PIN_OUTPUT_PULLDOWN | MUX_MODE2)	/* gpmc_a6.rgmii2_tclk */
-			0x40 (PIN_OUTPUT_PULLDOWN | MUX_MODE2)	/* gpmc_a0.rgmii2_tctl */
-			0x54 (PIN_OUTPUT_PULLDOWN | MUX_MODE2)	/* gpmc_a5.rgmii2_td0 */
-			0x50 (PIN_OUTPUT_PULLDOWN | MUX_MODE2)	/* gpmc_a4.rgmii2_td1 */
-			0x4c (PIN_OUTPUT_PULLDOWN | MUX_MODE2)	/* gpmc_a3.rgmii2_td2 */
-			0x48 (PIN_OUTPUT_PULLDOWN | MUX_MODE2)	/* gpmc_a2.rgmii2_td3 */
-			0x5c (PIN_INPUT_PULLDOWN | MUX_MODE2)	/* gpmc_a7.rgmii2_rclk */
-			0x44 (PIN_INPUT_PULLDOWN | MUX_MODE2)	/* gpmc_a1.rgmii2_rtcl */
-			0x6c (PIN_INPUT_PULLDOWN | MUX_MODE2)	/* gpmc_a11.rgmii2_rd0 */
-			0x68 (PIN_INPUT_PULLDOWN | MUX_MODE2)	/* gpmc_a10.rgmii2_rd1 */
-			0x64 (PIN_INPUT_PULLDOWN | MUX_MODE2)	/* gpmc_a9.rgmii2_rd2 */
-			0x60 (PIN_INPUT_PULLDOWN | MUX_MODE2)	/* gpmc_a8.rgmii2_rd3 */
+			0x58 (PIN_OUTPUT | MUX_MODE2)	/* gpmc_a6.rgmii2_tclk */
+			0x40 (PIN_OUTPUT | MUX_MODE2)	/* gpmc_a0.rgmii2_tctl */
+			0x54 (PIN_OUTPUT | MUX_MODE2)	/* gpmc_a5.rgmii2_td0 */
+			0x50 (PIN_OUTPUT | MUX_MODE2)	/* gpmc_a4.rgmii2_td1 */
+			0x4c (PIN_OUTPUT | MUX_MODE2)	/* gpmc_a3.rgmii2_td2 */
+			0x48 (PIN_OUTPUT | MUX_MODE2)	/* gpmc_a2.rgmii2_td3 */
+			0x5c (PIN_INPUT | MUX_MODE2)	/* gpmc_a7.rgmii2_rclk */
+			0x44 (PIN_INPUT | MUX_MODE2)	/* gpmc_a1.rgmii2_rtcl */
+			0x6c (PIN_INPUT | MUX_MODE2)	/* gpmc_a11.rgmii2_rd0 */
+			0x68 (PIN_INPUT | MUX_MODE2)	/* gpmc_a10.rgmii2_rd1 */
+			0x64 (PIN_INPUT | MUX_MODE2)	/* gpmc_a9.rgmii2_rd2 */
+			0x60 (PIN_INPUT | MUX_MODE2)	/* gpmc_a8.rgmii2_rd3 */
 		>;
 	};
 
@@ -257,8 +257,8 @@
 	davinci_mdio_default: davinci_mdio_default {
 		pinctrl-single,pins = <
 			/* MDIO */
-			0x148 (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE0)	/* mdio_data.mdio_data */
-			0x14c (PIN_OUTPUT_PULLUP | MUX_MODE0)			/* mdio_clk.mdio_clk */
+			0x148 (PIN_INPUT | SLEWCTRL_FAST | MUX_MODE0)	/* mdio_data.mdio_data */
+			0x14c (PIN_OUTPUT | MUX_MODE0)			/* mdio_clk.mdio_clk */
 		>;
 	};
 
-- 
2.1.0.GIT


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 4/6] arm: boot: dts: am437x-sk: add explicit pinmux for both USB instances
  2014-12-04 17:01 [PATCH 0/6] arm: boot: dts: am437x-sk: DTS pinmux fixes Felipe Balbi
                   ` (2 preceding siblings ...)
  2014-12-04 17:01 ` [PATCH 3/6] arm: boot: dts: am437x-sk: remove ethernet pulls Felipe Balbi
@ 2014-12-04 17:01 ` Felipe Balbi
  2014-12-04 17:01 ` [PATCH 5/6] arm: boot: dts: am437x-sk: remove internal i2c pullups Felipe Balbi
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Felipe Balbi @ 2014-12-04 17:01 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Linux OMAP Mailing List, Linux ARM Kernel Mailing List,
	Felipe Balbi

This patch just makes USB[01]_DRVVBUS signal
explicitly muxed. Note that board already has
a discrete pulldown, so we're not adding any
pulls here.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 arch/arm/boot/dts/am437x-sk-evm.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts
index 68b9529..5ca9ee7 100644
--- a/arch/arm/boot/dts/am437x-sk-evm.dts
+++ b/arch/arm/boot/dts/am437x-sk-evm.dts
@@ -329,6 +329,18 @@
 			0x1c (PIN_OUTPUT_PULLDOWN | MUX_MODE7) /* gpcm_ad7.gpio1_7 */
 		>;
 	};
+
+	usb1_pins: usb1_pins {
+		pinctrl-single,pins = <
+			0x2c0 (PIN_OUTPUT | MUX_MODE0) /* usb0_drvvbus.usb0_drvvbus */
+		>;
+	};
+
+	usb2_pins: usb2_pins {
+		pinctrl-single,pins = <
+			0x2c4 (PIN_OUTPUT | MUX_MODE0) /* usb0_drvvbus.usb0_drvvbus */
+		>;
+	};
 };
 
 &i2c0 {
@@ -485,6 +497,8 @@
 &usb1 {
 	dr_mode = "peripheral";
 	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&usb1_pins>;
 };
 
 &usb2_phy2 {
@@ -494,6 +508,8 @@
 &usb2 {
 	dr_mode = "host";
 	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&usb2_pins>;
 };
 
 &qspi {
-- 
2.1.0.GIT


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 5/6] arm: boot: dts: am437x-sk: remove internal i2c pullups
  2014-12-04 17:01 [PATCH 0/6] arm: boot: dts: am437x-sk: DTS pinmux fixes Felipe Balbi
                   ` (3 preceding siblings ...)
  2014-12-04 17:01 ` [PATCH 4/6] arm: boot: dts: am437x-sk: add explicit pinmux for both USB instances Felipe Balbi
@ 2014-12-04 17:01 ` Felipe Balbi
  2014-12-04 17:01 ` [PATCH 6/6] arm: boot: dts: am437x-sk: remove DSS pulls Felipe Balbi
       [not found] ` <20141204170415.GL18045@saruman>
  6 siblings, 0 replies; 9+ messages in thread
From: Felipe Balbi @ 2014-12-04 17:01 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Linux OMAP Mailing List, Linux ARM Kernel Mailing List,
	Felipe Balbi

AM437x Starter Kit already has discrete pullups
for all I2C buses, so we can (and should) remove
internal pulls.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 arch/arm/boot/dts/am437x-sk-evm.dts | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts
index 5ca9ee7..f8db9b9 100644
--- a/arch/arm/boot/dts/am437x-sk-evm.dts
+++ b/arch/arm/boot/dts/am437x-sk-evm.dts
@@ -153,15 +153,15 @@
 
 	i2c0_pins: i2c0_pins {
 		pinctrl-single,pins = <
-			0x188 (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE0)  /* i2c0_sda.i2c0_sda */
-			0x18c (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE0)  /* i2c0_scl.i2c0_scl */
+			0x188 (PIN_INPUT | SLEWCTRL_FAST | MUX_MODE0)  /* i2c0_sda.i2c0_sda */
+			0x18c (PIN_INPUT | SLEWCTRL_FAST | MUX_MODE0)  /* i2c0_scl.i2c0_scl */
 		>;
 	};
 
 	i2c1_pins: i2c1_pins {
 		pinctrl-single,pins = <
-			0x15c (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE2)  /* spi0_cs0.i2c1_scl */
-			0x158 (PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE2)  /* spi0_d1.i2c1_sda  */
+			0x15c (PIN_INPUT | SLEWCTRL_FAST | MUX_MODE2)  /* spi0_cs0.i2c1_scl */
+			0x158 (PIN_INPUT | SLEWCTRL_FAST | MUX_MODE2)  /* spi0_d1.i2c1_sda  */
 		>;
 	};
 
-- 
2.1.0.GIT


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 6/6] arm: boot: dts: am437x-sk: remove DSS pulls
  2014-12-04 17:01 [PATCH 0/6] arm: boot: dts: am437x-sk: DTS pinmux fixes Felipe Balbi
                   ` (4 preceding siblings ...)
  2014-12-04 17:01 ` [PATCH 5/6] arm: boot: dts: am437x-sk: remove internal i2c pullups Felipe Balbi
@ 2014-12-04 17:01 ` Felipe Balbi
       [not found] ` <20141204170415.GL18045@saruman>
  6 siblings, 0 replies; 9+ messages in thread
From: Felipe Balbi @ 2014-12-04 17:01 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Linux OMAP Mailing List, Linux ARM Kernel Mailing List,
	Felipe Balbi

The DSS data lines don't need pulls, it's best
to remove them to guarantee signal integrity.

Signed-off-by: Felipe Balbi <balbi@ti.com>
---
 arch/arm/boot/dts/am437x-sk-evm.dts | 56 ++++++++++++++++++-------------------
 1 file changed, 28 insertions(+), 28 deletions(-)

diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts
index f8db9b9..b459bd3 100644
--- a/arch/arm/boot/dts/am437x-sk-evm.dts
+++ b/arch/arm/boot/dts/am437x-sk-evm.dts
@@ -272,34 +272,34 @@
 
 	dss_pins: dss_pins {
 		pinctrl-single,pins = <
-			0x020 (PIN_OUTPUT_PULLUP | MUX_MODE1)	/* gpmc ad 8 -> DSS DATA 23 */
-			0x024 (PIN_OUTPUT_PULLUP | MUX_MODE1)
-			0x028 (PIN_OUTPUT_PULLUP | MUX_MODE1)
-			0x02c (PIN_OUTPUT_PULLUP | MUX_MODE1)
-			0x030 (PIN_OUTPUT_PULLUP | MUX_MODE1)
-			0x034 (PIN_OUTPUT_PULLUP | MUX_MODE1)
-			0x038 (PIN_OUTPUT_PULLUP | MUX_MODE1)
-			0x03c (PIN_OUTPUT_PULLUP | MUX_MODE1)	/* gpmc ad 15 -> DSS DATA 16 */
-			0x0a0 (PIN_OUTPUT_PULLUP | MUX_MODE0)	/* DSS DATA 0 */
-			0x0a4 (PIN_OUTPUT_PULLUP | MUX_MODE0)
-			0x0a8 (PIN_OUTPUT_PULLUP | MUX_MODE0)
-			0x0ac (PIN_OUTPUT_PULLUP | MUX_MODE0)
-			0x0b0 (PIN_OUTPUT_PULLUP | MUX_MODE0)
-			0x0b4 (PIN_OUTPUT_PULLUP | MUX_MODE0)
-			0x0b8 (PIN_OUTPUT_PULLUP | MUX_MODE0)
-			0x0bc (PIN_OUTPUT_PULLUP | MUX_MODE0)
-			0x0c0 (PIN_OUTPUT_PULLUP | MUX_MODE0)
-			0x0c4 (PIN_OUTPUT_PULLUP | MUX_MODE0)
-			0x0c8 (PIN_OUTPUT_PULLUP | MUX_MODE0)
-			0x0cc (PIN_OUTPUT_PULLUP | MUX_MODE0)
-			0x0d0 (PIN_OUTPUT_PULLUP | MUX_MODE0)
-			0x0d4 (PIN_OUTPUT_PULLUP | MUX_MODE0)
-			0x0d8 (PIN_OUTPUT_PULLUP | MUX_MODE0)
-			0x0dc (PIN_OUTPUT_PULLUP | MUX_MODE0)	/* DSS DATA 15 */
-			0x0e0 (PIN_OUTPUT_PULLUP | MUX_MODE0)	/* DSS VSYNC */
-			0x0e4 (PIN_OUTPUT_PULLUP | MUX_MODE0)	/* DSS HSYNC */
-			0x0e8 (PIN_OUTPUT_PULLUP | MUX_MODE0)	/* DSS PCLK */
-			0x0ec (PIN_OUTPUT_PULLUP | MUX_MODE0)	/* DSS AC BIAS EN */
+			0x020 (PIN_OUTPUT | MUX_MODE1)	/* gpmc ad 8 -> DSS DATA 23 */
+			0x024 (PIN_OUTPUT | MUX_MODE1)
+			0x028 (PIN_OUTPUT | MUX_MODE1)
+			0x02c (PIN_OUTPUT | MUX_MODE1)
+			0x030 (PIN_OUTPUT | MUX_MODE1)
+			0x034 (PIN_OUTPUT | MUX_MODE1)
+			0x038 (PIN_OUTPUT | MUX_MODE1)
+			0x03c (PIN_OUTPUT | MUX_MODE1)	/* gpmc ad 15 -> DSS DATA 16 */
+			0x0a0 (PIN_OUTPUT | MUX_MODE0)	/* DSS DATA 0 */
+			0x0a4 (PIN_OUTPUT | MUX_MODE0)
+			0x0a8 (PIN_OUTPUT | MUX_MODE0)
+			0x0ac (PIN_OUTPUT | MUX_MODE0)
+			0x0b0 (PIN_OUTPUT | MUX_MODE0)
+			0x0b4 (PIN_OUTPUT | MUX_MODE0)
+			0x0b8 (PIN_OUTPUT | MUX_MODE0)
+			0x0bc (PIN_OUTPUT | MUX_MODE0)
+			0x0c0 (PIN_OUTPUT | MUX_MODE0)
+			0x0c4 (PIN_OUTPUT | MUX_MODE0)
+			0x0c8 (PIN_OUTPUT | MUX_MODE0)
+			0x0cc (PIN_OUTPUT | MUX_MODE0)
+			0x0d0 (PIN_OUTPUT | MUX_MODE0)
+			0x0d4 (PIN_OUTPUT | MUX_MODE0)
+			0x0d8 (PIN_OUTPUT | MUX_MODE0)
+			0x0dc (PIN_OUTPUT | MUX_MODE0)	/* DSS DATA 15 */
+			0x0e0 (PIN_OUTPUT | MUX_MODE0)	/* DSS VSYNC */
+			0x0e4 (PIN_OUTPUT | MUX_MODE0)	/* DSS HSYNC */
+			0x0e8 (PIN_OUTPUT | MUX_MODE0)	/* DSS PCLK */
+			0x0ec (PIN_OUTPUT | MUX_MODE0)	/* DSS AC BIAS EN */
 
 		>;
 	};
-- 
2.1.0.GIT


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 0/6] arm: boot: dts: am437x-sk: DTS pinmux fixes
       [not found] ` <20141204170415.GL18045@saruman>
@ 2014-12-04 17:06   ` Felipe Balbi
  2015-01-07 23:16     ` Tony Lindgren
  0 siblings, 1 reply; 9+ messages in thread
From: Felipe Balbi @ 2014-12-04 17:06 UTC (permalink / raw)
  To: Felipe Balbi
  Cc: Tony Lindgren, Linux OMAP Mailing List,
	Linux ARM Kernel Mailing List

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

Hi,

On Thu, Dec 04, 2014 at 11:04:15AM -0600, Felipe Balbi wrote:
> > Here's a small series of non-critical fixes and improvements
> > for AM437x Starter Kit DTS.
> > 
> > Basically I'm removing unnecessary pulls and adding explicit
> > pinmux for a couple interfaces which were missing.
> > 
> > All patches tested on top of commit 1ca7c60 (Add linux-next
> > specific files for 20141204). Boot logs will be attached as
> > a reply here.
> 
> boot log attached.

no idea why the thing says "-dirty". Just reboot and I get:

# uname -a
Linux saruman 3.18.0-rc7-next-20141204-00009-g8ade679 #2348 SMP Thu Dec 4 11:04:44 CST 2014 armv7l GNU/Linux

cheers

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 0/6] arm: boot: dts: am437x-sk: DTS pinmux fixes
  2014-12-04 17:06   ` [PATCH 0/6] arm: boot: dts: am437x-sk: DTS pinmux fixes Felipe Balbi
@ 2015-01-07 23:16     ` Tony Lindgren
  0 siblings, 0 replies; 9+ messages in thread
From: Tony Lindgren @ 2015-01-07 23:16 UTC (permalink / raw)
  To: Felipe Balbi; +Cc: Linux OMAP Mailing List, Linux ARM Kernel Mailing List

* Felipe Balbi <balbi@ti.com> [141204 09:09]:
> Hi,
> 
> On Thu, Dec 04, 2014 at 11:04:15AM -0600, Felipe Balbi wrote:
> > > Here's a small series of non-critical fixes and improvements
> > > for AM437x Starter Kit DTS.
> > > 
> > > Basically I'm removing unnecessary pulls and adding explicit
> > > pinmux for a couple interfaces which were missing.
> > > 
> > > All patches tested on top of commit 1ca7c60 (Add linux-next
> > > specific files for 20141204). Boot logs will be attached as
> > > a reply here.
> > 
> > boot log attached.
> 
> no idea why the thing says "-dirty". Just reboot and I get:
> 
> # uname -a
> Linux saruman 3.18.0-rc7-next-20141204-00009-g8ade679 #2348 SMP Thu Dec 4 11:04:44 CST 2014 armv7l GNU/Linux

Applying all these into omap-for-v3.20/dt thanks.

Tony

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2015-01-07 23:20 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-04 17:01 [PATCH 0/6] arm: boot: dts: am437x-sk: DTS pinmux fixes Felipe Balbi
2014-12-04 17:01 ` [PATCH 1/6] arm: boot: dts: am437x-sk: remove internal pulls from QSPI Felipe Balbi
2014-12-04 17:01 ` [PATCH 2/6] arm: boot: dts: am437x-sk: add explicit MMC0 pinmux Felipe Balbi
2014-12-04 17:01 ` [PATCH 3/6] arm: boot: dts: am437x-sk: remove ethernet pulls Felipe Balbi
2014-12-04 17:01 ` [PATCH 4/6] arm: boot: dts: am437x-sk: add explicit pinmux for both USB instances Felipe Balbi
2014-12-04 17:01 ` [PATCH 5/6] arm: boot: dts: am437x-sk: remove internal i2c pullups Felipe Balbi
2014-12-04 17:01 ` [PATCH 6/6] arm: boot: dts: am437x-sk: remove DSS pulls Felipe Balbi
     [not found] ` <20141204170415.GL18045@saruman>
2014-12-04 17:06   ` [PATCH 0/6] arm: boot: dts: am437x-sk: DTS pinmux fixes Felipe Balbi
2015-01-07 23:16     ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).