From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nishanth Menon Subject: Re: [PATCH v2 14/21] ARM: imx6: convert GPC to stacked domains Date: Thu, 8 Jan 2015 10:57:17 -0600 Message-ID: <20150108165717.GA19124@kahuna> References: <1420652576-22309-1-git-send-email-marc.zyngier@arm.com> <1420652576-22309-15-git-send-email-marc.zyngier@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:55788 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756934AbbAHQ6I (ORCPT ); Thu, 8 Jan 2015 11:58:08 -0500 Content-Disposition: inline In-Reply-To: <1420652576-22309-15-git-send-email-marc.zyngier@arm.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Marc Zyngier Cc: Stephen Warren , Thierry Reding , Alexandre Courbot , Benoit Cousson , Tony Lindgren , Santosh Shilimkar , Shawn Guo , Sascha Hauer , Kukjin Kim , Simon Horman , Magnus Damm , Linus Walleij , Michal Simek , Rob Herring , Mark Rutland , Jason Cooper , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-omap@vger.kernel.org On 17:42-20150107, Marc Zyngier wrote: > IMX6 has been (ab)using the gic_arch_extn to provide > wakeup from suspend, and it makes a lot of sense to convert > this code to use stacked domains instead. > > This patch does just this, updating the DT files to actually > reflect what the HW provides. > minor checkpatch warnings below: @@ -0,0 +1,14 @@ +CHECK: Alignment should match open parenthesis +#249: FILE: arch/arm/mach-imx/gpc.c:158: ++static int imx_gpc_domain_alloc(struct irq_domain *domain, ++ unsigned int virq, +WARNING: line over 80 characters +#272: FILE: arch/arm/mach-imx/gpc.c:181: ++ return irq_domain_alloc_irqs_parent(domain, virq, nr_irqs, &parent_args); +ERROR: code indent should use tabs where possible +#305: FILE: arch/arm/mach-imx/gpc.c:209: ++^I return -ENOMEM;$ +NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or + scripts/cleanfile -- Regards, Nishanth Menon