Re: [PATCH 2/4] usb: dwc3: gadget: Stop TRB preparation after limit is reached

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 2262 bytes --]

Hi,

On Tue, Jan 13, 2015 at 10:18:20AM +0530, Amit Virdi wrote:
> On 1/13/2015 12:04 AM, Felipe Balbi wrote:
> >Hi,
> >
> >On Tue, Jan 06, 2015 at 11:44:23AM +0530, Amit Virdi wrote:
> >>>>>>I can certainly provide the dwc3 specific kernel bootup logs, full
> >>>>>>regdump and any loglevel you want me to, if that helps
> >>>>>
> >>>>>Yeah, if you can provide those, then that'll help me verifying. Full
> >>>>>logs from boot to failure point with VERBOSE_DEBUG enabled (considering
> >>>>>you're not running on anything recent).
> >>>>>
> >>>>
> >>>>Okay. I'll provide full verbose logs, along with the register dump,
> >>>>when I'm back to the office next week, for the working and non-working
> >>>>case, but how - as attachment or as inline?
> >>>
> >>>Either way will do but I have a feeling mailing list attachment size
> >>>will bite you, so maybe it's best to make a tarball of both logs and
> >>>send that as attachment. Compressed text will be very small.
> >>>
> >>
> >>Attached are the dwc3 verbose logs and register dump without and with the
> >>fixes in this patchset.
> >
> >Sorry for the long delay, it has been a bit hectic.
> >
> 
> It's okay!
> 
> >I can see from your logs that we end up with a Transfer Not Ready
> >(Transfer Active) event and endpoint has BUSY flag set. I also see that
> >you're queueing 31 requests and all of them will use 2 TRBs, so we
> >clearly go over our TRB table.
> >
> >This fix is, indeed, necessary but we need to improve commit log a bit
> >so it's extremely clear what the error is. Later, we can improve how we
> >handle requests in this driver, but that is outside of the scope of your
> >patchset.
> >
> >Please improve commit log and resend your series so it can be applied.
> >
> 
> Alright! I'll improve the commit messages and, also, cc stable list while
> resending the patches. As I see, you have already picked patches [3/4] and
> [4/4]. So, I'll resend only [1/4] and [2/4]
> 
> >cheers
> >
> 
> Thank you for your patience and kind understanding.

Alright, I just applied your patches to testing/fixes. I'll start
testing today and should be able to send a pull request to Greg by the
end of the week, hopefully.

cheers

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]