linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Sebastian Reichel <sre@ring0.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
	aaro.koskinen@iki.fi, freemangordon@abv.bg
Subject: Re: n900: kernel cmdline from bootloader in DT mode
Date: Sat, 24 Jan 2015 15:01:19 +0100	[thread overview]
Message-ID: <201501241501.20009@pali> (raw)
In-Reply-To: <201411261627.57241@pali>

[-- Attachment #1: Type: Text/Plain, Size: 1844 bytes --]

On Wednesday 26 November 2014 16:27:57 Pali Rohár wrote:
> On Wednesday 26 November 2014 16:22:00 Pavel Machek wrote:
> > On Wed 2014-11-26 14:36:42, Pali Rohár wrote:
> > > On Wednesday 26 November 2014 14:28:01 Pavel Machek wrote:
> > > > Hi!
> > > > 
> > > > > for some unknown reasons when I compile kernel for
> > > > > n900 in DT mode it ignore cmdline passed by
> > > > > bootloader. When I comment
> > > > > 
> > > > > CONFIG_ARM_APPENDED_DTB=y
> > > > > 
> > > > > then it boots into legacy board mode and cmdline is
> > > > > used from bootloader.
> > > > > 
> > > > > When is problem?
> > > > 
> > > > It seems to work for me, I'm booting using 0xffff, with
> > > > attached config.
> > > > 
> > > > 									Pavel
> > > 
> > > Can you try to set some "root=something" into
> > > CONFIG_CMDLINE and then add real "root=" param via
> > > 0xffff?
> > > 
> > > My problem is that I have specified ubifs mtd root in
> > > CONFIG_CMDLINE and when I set correct root via bootloader
> > > (from 0xffff or flasher-3.5) it is ignored and used only
> > > what is specified in CONFIG_CMDLINE.
> > 
> > CONFIG_ARM_ATAG_DTB_COMPAT=y
> > CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER=y
> > # CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_EXTEND is not set
> > CONFIG_CMDLINE="console=ttyO2,115200 console=tty"
> > 
> > Um.. Internal commandline should be completely ignored for
> > me.
> > 
> > Do you have
> > CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER?
> > 
> > 									Pavel
> 
> Yes, I have:
> 
> CONFIG_ARM_APPENDED_DTB=y
> CONFIG_ARM_ATAG_DTB_COMPAT=y
> CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER=y
> CONFIG_CMDLINE="...."
> CONFIG_CMDLINE_FROM_BOOTLOADER=y

Problem detected and fix patch here:
https://lkml.org/lkml/2015/1/23/701

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2015-01-24 14:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26 12:54 n900: kernel cmdline from bootloader in DT mode Pali Rohár
2014-11-26 13:28 ` Pavel Machek
2014-11-26 13:36   ` Pali Rohár
2014-11-26 15:22     ` Pavel Machek
2014-11-26 15:27       ` Pali Rohár
2015-01-24 14:01         ` Pali Rohár [this message]
2014-11-26 23:25       ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201501241501.20009@pali \
    --to=pali.rohar@gmail.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=freemangordon@abv.bg \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=sre@ring0.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).