From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH 1/4] arm: omap: hwmod: 43xx: add DebugSS hwmod data Date: Mon, 26 Jan 2015 13:49:33 -0600 Message-ID: <20150126194933.GG6660@saruman.tx.rr.com> References: <1422054704-14915-1-git-send-email-balbi@ti.com> <1422054704-14915-2-git-send-email-balbi@ti.com> <20150126165640.GA10679@saruman.tx.rr.com> Reply-To: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cyV/sMl4KAhiehtf" Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:54278 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753120AbbAZTuE (ORCPT ); Mon, 26 Jan 2015 14:50:04 -0500 Content-Disposition: inline In-Reply-To: <20150126165640.GA10679@saruman.tx.rr.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Balbi Cc: Paul Walmsley , Tony Lindgren , Linux OMAP Mailing List , Linux ARM Kernel Mailing List , devicetree@vger.kernel.org --cyV/sMl4KAhiehtf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Jan 26, 2015 at 10:56:40AM -0600, Felipe Balbi wrote: > > the references below are from SPRUHL7 > >=20 > > On Fri, 23 Jan 2015, Felipe Balbi wrote: > >=20 > > > Without hwmod data for DebugSS, performance monitors > > > have no chance of running on AM43xx devices. > > >=20 > > > Signed-off-by: Felipe Balbi > > > --- > > > arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 40 ++++++++++++++++++++= ++++++++++ > > > arch/arm/mach-omap2/prcm43xx.h | 1 + > > > 2 files changed, 41 insertions(+) > > >=20 > > > diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c b/arch/arm/ma= ch-omap2/omap_hwmod_43xx_data.c > > > index 5c6c8410160e..6709704dd5b5 100644 > > > --- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c > > > +++ b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c > > > @@ -19,6 +19,7 @@ > > > #include "omap_hwmod.h" > > > #include "omap_hwmod_33xx_43xx_common_data.h" > > > #include "prcm43xx.h" > > > +#include "prm44xx.h" > > > #include "omap_hwmod_common_data.h" > > > =20 > > > =20 > > > @@ -60,6 +61,44 @@ static struct omap_hwmod am43xx_wkup_m3_hwmod =3D { > > > .rst_lines_cnt =3D ARRAY_SIZE(am33xx_wkup_m3_resets), > > > }; > > > =20 > > > +/* > > > + * 'debugss' class > > > + * debug and emulation sub system > > > + */ > > > +static struct omap_hwmod_opt_clk am43xx_debugss_opt_clks[] =3D { > > > + { .role =3D "dbg_sysclk", .clk =3D "dbg_sysclk_ck" }, > > > + { .role =3D "dbg_clka", .clk =3D "dbg_clka_ck", }, > > > + { .role =3D "dbg_clkb", .clk =3D "dbg_clkb_ck", }, > > > + { .role =3D "dbg_clkc", .clk =3D "dbg_clkc_ck", }, > > > +}; > > > + > > > +static struct omap_hwmod_class am43xx_debugss_hwmod_class =3D { > > > + .name =3D "debugss", > > > +}; > > > + > > > +/* debugss */ > > > +static struct omap_hwmod am43xx_debugss_hwmod =3D { > > > + .name =3D "debugss", > > > + .class =3D &am43xx_debugss_hwmod_class, > > > + .clkdm_name =3D "l3_aon_clkdm", > > > + .main_clk =3D "trace_clk_div_ck", > > > + .prcm =3D { > > > + .omap4 =3D { > > > + .clkctrl_offs =3D AM43XX_CM_WKUP_DBGSS_CLKCTRL_OFFSET, > >=20 > > According to Table 6-275 "PRCM_CM_WKUP_DBGSS_CLKCTRL Register Field=20 > > Descriptions" this should have a=20 > >=20 > > .modulemode =3D MODULEMODE_SWCTRL, >=20 > hm... modulemode SWCTRL causes wait_target_ready to fail. Any hints ? gets stuck in transition state. PRCM_CM_WKUP_DBGSS_CLKCTRL is always read as 0x 12510f00 which would translate into: - module disabled - all opt clocks are on - module is transitioning - module in standby - clkA as TPIU and STM trace clock - all dividers set to 2 --=20 balbi --cyV/sMl4KAhiehtf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUxppNAAoJEIaOsuA1yqRE03oP/iz4b6HWwuV/aZR99tL0+J4K K277SUKKsK/qaY6nNadlXMFmI4sOBGOy2o6m76tyJNUiSq0u8wMJFoGGayAULKJw XRUXeAElv6+OQfysBIWBNz4fbYzhMFLX90q/OIyrYlrmnYnAScoZ4e8FUhaDhoX0 bLaA1CFZ2jiA5BziRsSaQkC7sE8z4O00Ofwv08rQqt15RbBG/IsstPcfRpelY/rR UdjEEydsUI+le4SRxdzzlcSxKJLP5fIsUS/zWXPoRQwC6Jmb99cAytnMGeS1SZj1 1G4zijPyXuIcuar7L10uFFrSA6D38PjoUis2XSopky3fdLxT6tSx+Ufm2SHlt1CK ViWgirFxp+/sqEWnO9u2foxpfMcXNX1lXjPDgDWLoHzuc6uQw7+QH9irKUB3Apos mDud19Kl5xGKiANja0M0VribSIbDs2zb4DvqgFBvok++B+D2w8ONqQ/UPk94WBZc lRiYWS6fa3m+aDDG5pI9UKwcmI+FTK7pIKHWj8lGenuszOxrBRSPumrtuH/hrKKH /gDppOn33+yv3h9Ksr5VJ/53ejgZjaU4GXHHe/3JCX8Vf4ITIjHz284qmCokW9xf IfCGYZd9fx6J+CdN9Wp7ihk2UX6tr+3B+W7Sy3s/IH72G349rbI7Ws81gqszrgw6 /LA+/IwWlXjnsJjc+2fV =XM3c -----END PGP SIGNATURE----- --cyV/sMl4KAhiehtf--