From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?q?Roh=C3=A1r?= Subject: Re: [PATCH] ARM: dts: Revert disabling of smc91x for n900 Date: Wed, 18 Feb 2015 16:19:46 +0100 Message-ID: <201502181619.46278@pali> References: <20150105230228.GO4081@atomide.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart28493419.S5QZV0DZ1I"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150105230228.GO4081@atomide.com> Sender: linux-kernel-owner@vger.kernel.org To: Tony Lindgren Cc: linux-omap@vger.kernel.org, Kevin Hilman , Aaro Koskinen , Sebastian Reichel , Pavel Machek , linux-kernel@vger.kernel.org, Ivaylo Dimitrov , Nishanth Menon List-Id: linux-omap@vger.kernel.org --nextPart28493419.S5QZV0DZ1I Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Tuesday 06 January 2015 00:02:29 Tony Lindgren wrote: > Revert "ARM: dts: Disable smc91x on n900 until bootloader > dependency is removed". We've now fixed the issues that > caused problems with uninitialized hardware depending on > the bootloader version. Mostly things got fixed with > the following commits: >=20 > 9a894953a97b ("ARM: dts: Fix bootloader version dependencies > by muxing n900 smc91x pins") 7d2911c43815 ("net: smc91x: Fix > gpios for device tree based booting") >=20 > Note that this only affects the early development boards > with Ethernet that we still have in a few automated boot > test systems. >=20 > Signed-off-by: Tony Lindgren >=20 > --- a/arch/arm/boot/dts/omap3-n900.dts > +++ b/arch/arm/boot/dts/omap3-n900.dts > @@ -702,9 +702,6 @@ >=20 > ethernet@gpmc { > compatible =3D "smsc,lan91c94"; > - > - status =3D "disabled"; > - > interrupt-parent =3D <&gpio2>; > interrupts =3D <22 IRQ_TYPE_LEVEL_HIGH>; /* gpio54 */ > reg =3D <1 0x300 0xf>; /* 16 byte IO range at offset 0x300 > */ Hello Tony, to make smc ethernet working in n900 qemu I needed to apply this patch: diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n90= 0.dts index ff36fbe..d96eeb8 100644 =2D-- a/arch/arm/boot/dts/omap3-n900.dts +++ b/arch/arm/boot/dts/omap3-n900.dts @@ -770,7 +770,8 @@ compatible =3D "smsc,lan91c94"; interrupt-parent =3D <&gpio2>; interrupts =3D <22 IRQ_TYPE_LEVEL_HIGH>; /* gpio54 */ =2D reg =3D <1 0x300 0xf>; /* 16 byte IO range at offset 0x300 */ +// reg =3D <1 0x300 0xf>; /* 16 byte IO range at offset 0x300 */ + reg =3D <1 0x0 0xf>; /* 16 byte IO range at offset 0x300 */ bank-width =3D <2>; pinctrl-names =3D "default"; pinctrl-0 =3D <ðernet_pins>; With this patch I see in dmesg: [ 20.577911] smc91x 2000000.ethernet (unnamed net_device) (uninitialized)= : smc91x: smc_probe [ 20.580535] smc91x 2000000.ethernet (unnamed net_device) (uninitialized)= : smc91x: bank signature probe=20 returned 0x3300 [ 20.585327] smc91x 2000000.ethernet (unnamed net_device) (uninitialized)= : smc91x: revision =3D 0x3391 [ 20.590087] smc91x.c: v1.1, sep 22 2004 by Nicolas Pitre [ 20.593627] smc91x 2000000.ethernet (unnamed net_device) (uninitialized)= : smc_reset [ 20.596832] smc91x 2000000.ethernet (unnamed net_device) (uninitialized)= : smc_phy_detect [ 20.611938] smc91x 2000000.ethernet (unnamed net_device) (uninitialized)= : smc91x: smc_shutdown [ 20.615875] smc91x 2000000.ethernet eth0: SMC91C11xFD (rev 1) at d08be00= 0 IRQ 166 [ 20.618682]=20 [ 20.621124] smc91x 2000000.ethernet eth0: Ethernet addr: 52:54:00:12:34:= 56 [ 20.624938] smc91x 2000000.ethernet eth0: No PHY found (and eth0 exists in ifconfig) If I do not apply my patch I got this error message: [ 22.134704] smc91x 2000300.ethernet (unnamed net_device) (uninitialized)= : smc91x: bank signature probe=20 returned 0x0000 [ 22.140014] smc91x: not found (-19). and no ethernet device was registered. With 2.6.28 kernel with N900 patches (but smc91x is unmodified!) ethernet d= evice is working fine. =2D-=20 Pali Roh=C3=A1r pali.rohar@gmail.com --nextPart28493419.S5QZV0DZ1I Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEABECAAYFAlTkrZIACgkQi/DJPQPkQ1KGMQCfQYEk6us4a3ZJNeucTvwTkO4e du8An1BNmO0VHa6Z5jUWb3w9crUkQELf =rL0W -----END PGP SIGNATURE----- --nextPart28493419.S5QZV0DZ1I--