From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: Nokia N900: omap aes is broken Date: Tue, 24 Feb 2015 09:37:34 -0800 Message-ID: <20150224173734.GD28244@atomide.com> References: <201502181321.03774@pali> <201502182227.55488@pali> <20150224172512.GC28244@atomide.com> <201502241838.44317@pali> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from pmta2.delivery7.ore.mailhop.org ([54.149.205.143]:48790 "EHLO pmta2.delivery7.ore.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753346AbbBXRlw (ORCPT ); Tue, 24 Feb 2015 12:41:52 -0500 Content-Disposition: inline In-Reply-To: <201502241838.44317@pali> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Pali =?utf-8?B?Um9ow6Fy?= Cc: Nishanth Menon , Felipe Balbi , Ivaylo Dimitrov , Aaro Koskinen , Sebastian Reichel , Pavel Machek , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-crypto@vger.kernel.org * Pali Roh=C3=A1r [150224 09:42]: > On Tuesday 24 February 2015 18:25:12 Tony Lindgren wrote: > > * Pali Roh=C3=A1r [150218 16:03]: > > > --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > > > +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c > > > @@ -3938,8 +3938,9 @@ int __init omap3xxx_hwmod_init(void) > > >=20 > > > if (r < 0) > > > =09 > > > return r; > > >=20 > > > - /* Register GP-only hwmod links. */ > > > - if (h_gp && omap_type() =3D=3D OMAP2_DEVICE_TYPE_GP) { > > > +// /* Register GP-only hwmod links. */ > > > +// if (h_gp && omap_type() =3D=3D OMAP2_DEVICE_TYPE_GP) { > > > + if (h_gp) { > > >=20 > > > r =3D omap_hwmod_register_links(h_gp); > > > if (r < 0) > > > =09 > > > return r; > > >=20 > > > aes hwmod is defined in GP-only hwmod... > >=20 > > Doesn't this depend on the bootloader version of n900 to work? > >=20 > > Regards, > >=20 > > Tony >=20 > Ok, it looks like second patch (omap_hwmod_3xxx_data.c) needs=20 > that aes-enabled bootloader. OK we need some runtime detection somehow for what's enabled.. =20 > But first patch (omap3.dtsi) is needed for proper definitions.=20 > Otherwise omap-aes driver will never work on DT systems. Yeah that one makes sense to me, I guess you'll do a proper fix for that one. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html