From: Pavel Machek <pavel@ucw.cz>
To: NeilBrown <neilb@suse.de>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Tony Lindgren <tony@atomide.com>,
Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
GTA04 owners <gta04-owner@goldelico.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 11/15] twl4030_charger: enable manual enable/disable of usb charging.
Date: Wed, 4 Mar 2015 11:19:41 +0100 [thread overview]
Message-ID: <20150304101941.GB30887@amd> (raw)
In-Reply-To: <20150304171509.2516f1ba@notabene.brown>
On Wed 2015-03-04 17:15:09, NeilBrown wrote:
> On Mon, 2 Mar 2015 22:03:42 +0100 Pavel Machek <pavel@ucw.cz> wrote:
>
> > On Tue 2015-02-24 15:33:52, NeilBrown wrote:
> > > 'off' or 'auto' to
> > >
> > > /sys/class/power/twl4030_usb/mode
> > >
> > > will now enable or disable charging from USB port. Normally this is
> > > enabled on 'plug' and disabled on 'unplug'.
> > > Unplug will still disable charging. 'plug' will only enable it if
> > > 'auto' if selected.
> >
> > This should go to Documentation/
>
> You mean in Documentation/ABI/stable I guess??
Yes.
> That strikes me as a failed experiment - there is hardly anything there.
>
> I'd be very happy to put the documentation with the code if there was some
> mechanism to automatically extract it. But I really see little value in
> Documentation/ABI.
It was useful in past, and rules say it is required. Feel free to talk
to greg about better place, but this is the place we have now and
documentation is useful. And since you already document it in the
changelogs... it should not be that much work.
> > Acked-by: Pavel Machek <pavel@ucw.cz>
>
> Thanks a lot!
You are welcome :-).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2015-03-04 10:19 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 4:33 [PATCH 00/15] Enhance twl4030_charger functionality NeilBrown
2015-02-24 4:33 ` [PATCH 03/15] twl4030_charger: use devres for power_supply_register and kzalloc NeilBrown
2015-03-07 20:25 ` Sebastian Reichel
2015-02-24 4:33 ` [PATCH 01/15] power_supply core: support use of devres to register/unregister a power supply NeilBrown
2015-02-26 2:25 ` Sebastian Reichel
2015-02-24 4:33 ` [PATCH 02/15] twl4030_charger: use devm_request_threaded_irq NeilBrown
2015-02-24 4:33 ` [PATCH 06/15] twl4030_charger: split uA calculation into a function NeilBrown
2015-03-02 21:05 ` Pavel Machek
2015-03-04 9:20 ` NeilBrown
2015-02-24 4:33 ` [PATCH 08/15] twl4030_charger: distinguish between USB current and 'AC' current NeilBrown
2015-03-02 21:05 ` Pavel Machek
2015-03-04 6:53 ` NeilBrown
2015-02-24 4:33 ` [PATCH 05/15] twl4030_charger: trust phy to determine when USB power is available NeilBrown
2015-02-24 4:33 ` [PATCH 04/15] twl4030_charger: use runtime_pm to keep usb phy active while charging NeilBrown
2015-02-25 7:24 ` Lee Jones
2015-03-05 5:48 ` NeilBrown
2015-02-24 4:33 ` [PATCH 07/15] twl4030_charger: allow fine control of charger current NeilBrown
2015-03-02 21:05 ` Pavel Machek
2015-03-04 6:47 ` NeilBrown
2015-03-04 10:24 ` Pavel Machek
2015-03-07 20:32 ` Sebastian Reichel
2015-02-24 4:33 ` [PATCH 10/15] twl4030_charger: only draw USB current as negotiated with host NeilBrown
2015-03-02 21:05 ` Pavel Machek
2015-02-24 4:33 ` [PATCH 09/15] twl4030_charger: allow max_current to be managed via sysfs NeilBrown
2015-03-02 21:05 ` Pavel Machek
2015-03-05 6:26 ` NeilBrown
2015-03-05 8:17 ` Pavel Machek
2015-03-07 20:37 ` Sebastian Reichel
2015-02-24 4:33 ` [PATCH 11/15] twl4030_charger: enable manual enable/disable of usb charging NeilBrown
2015-03-02 21:03 ` Pavel Machek
2015-03-04 6:15 ` NeilBrown
2015-03-04 10:19 ` Pavel Machek [this message]
2015-02-24 4:33 ` [PATCH 12/15] twl4030_charger: add software controlled linear charging mode NeilBrown
2015-03-02 21:09 ` Pavel Machek
2015-03-05 6:33 ` NeilBrown
2015-03-06 21:24 ` twl4030_charger: need changes to get probed? Pavel Machek
2015-03-06 21:57 ` Pali Rohár
2015-03-06 22:12 ` Grazvydas Ignotas
2015-03-06 22:40 ` Pavel Machek
2015-03-06 22:56 ` Pali Rohár
2015-03-07 15:56 ` Grazvydas Ignotas
2015-03-07 16:43 ` Pali Rohár
2015-04-26 10:13 ` Pavel Machek
2015-03-07 21:01 ` Sebastian Reichel
2015-03-09 0:06 ` NeilBrown
2015-03-09 11:14 ` Sebastian Reichel
2015-02-24 4:33 ` [PATCH 15/15] twl4030_charger: assume a 'charger' can supply maximum current NeilBrown
2015-03-02 21:29 ` Pavel Machek
2015-03-05 6:45 ` NeilBrown
2015-02-24 4:33 ` [PATCH 13/15] twl4030_charger: add ac/mode to match usb/mode NeilBrown
2015-03-02 21:13 ` Pavel Machek
2015-03-06 21:59 ` Grazvydas Ignotas
2015-03-22 23:13 ` NeilBrown
2015-02-24 4:33 ` [PATCH 14/15] twl4030_charger: Increase current carefully while watching voltage NeilBrown
2015-03-02 21:29 ` Pavel Machek
2015-03-05 6:51 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304101941.GB30887@amd \
--to=pavel@ucw.cz \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gta04-owner@goldelico.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=neilb@suse.de \
--cc=sameo@linux.intel.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).