* [PATCH] dma: cppi41: add missing directions bitfield
@ 2015-02-25 22:54 Felipe Balbi
2015-03-04 12:43 ` Vinod Koul
0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2015-02-25 22:54 UTC (permalink / raw)
To: Vinod Koul
Cc: dmaengine-u79uwXL29TY76Z2rM5mHXA, Linux USB Mailing List,
Linux OMAP Mailing List, Dan Williams, Felipe Balbi
Without those we will see a kernel WARN()
when loading musb on am335x devices.
Signed-off-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
---
drivers/dma/cppi41.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
index 512cb8e2805e..4e9cc8e8100c 100644
--- a/drivers/dma/cppi41.c
+++ b/drivers/dma/cppi41.c
@@ -926,6 +926,7 @@ static int cppi41_dma_probe(struct platform_device *pdev)
cdd->ddev.device_issue_pending = cppi41_dma_issue_pending;
cdd->ddev.device_prep_slave_sg = cppi41_dma_prep_slave_sg;
cdd->ddev.device_terminate_all = cppi41_stop_chan;
+ cdd->ddev.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
cdd->ddev.dev = dev;
INIT_LIST_HEAD(&cdd->ddev.channels);
cpp41_dma_info.dma_cap = cdd->ddev.cap_mask;
--
2.3.0
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dma: cppi41: add missing directions bitfield
2015-02-25 22:54 [PATCH] dma: cppi41: add missing directions bitfield Felipe Balbi
@ 2015-03-04 12:43 ` Vinod Koul
2015-03-09 15:50 ` Felipe Balbi
0 siblings, 1 reply; 3+ messages in thread
From: Vinod Koul @ 2015-03-04 12:43 UTC (permalink / raw)
To: Felipe Balbi
Cc: dmaengine, Linux USB Mailing List, Linux OMAP Mailing List,
Dan Williams
On Wed, Feb 25, 2015 at 04:54:02PM -0600, Felipe Balbi wrote:
> Without those we will see a kernel WARN()
> when loading musb on am335x devices.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
> drivers/dma/cppi41.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
> index 512cb8e2805e..4e9cc8e8100c 100644
> --- a/drivers/dma/cppi41.c
> +++ b/drivers/dma/cppi41.c
> @@ -926,6 +926,7 @@ static int cppi41_dma_probe(struct platform_device *pdev)
> cdd->ddev.device_issue_pending = cppi41_dma_issue_pending;
> cdd->ddev.device_prep_slave_sg = cppi41_dma_prep_slave_sg;
> cdd->ddev.device_terminate_all = cppi41_stop_chan;
> + cdd->ddev.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
> cdd->ddev.dev = dev;
> INIT_LIST_HEAD(&cdd->ddev.channels);
> cpp41_dma_info.dma_cap = cdd->ddev.cap_mask;
Along with this please set src/dstn_addr_widths and residue_granularity
please
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dma: cppi41: add missing directions bitfield
2015-03-04 12:43 ` Vinod Koul
@ 2015-03-09 15:50 ` Felipe Balbi
0 siblings, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2015-03-09 15:50 UTC (permalink / raw)
To: Vinod Koul
Cc: Felipe Balbi, dmaengine, Linux USB Mailing List,
Linux OMAP Mailing List, Dan Williams
[-- Attachment #1: Type: text/plain, Size: 1106 bytes --]
On Wed, Mar 04, 2015 at 06:13:23PM +0530, Vinod Koul wrote:
> On Wed, Feb 25, 2015 at 04:54:02PM -0600, Felipe Balbi wrote:
> > Without those we will see a kernel WARN()
> > when loading musb on am335x devices.
> >
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > ---
> > drivers/dma/cppi41.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c
> > index 512cb8e2805e..4e9cc8e8100c 100644
> > --- a/drivers/dma/cppi41.c
> > +++ b/drivers/dma/cppi41.c
> > @@ -926,6 +926,7 @@ static int cppi41_dma_probe(struct platform_device *pdev)
> > cdd->ddev.device_issue_pending = cppi41_dma_issue_pending;
> > cdd->ddev.device_prep_slave_sg = cppi41_dma_prep_slave_sg;
> > cdd->ddev.device_terminate_all = cppi41_stop_chan;
> > + cdd->ddev.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
> > cdd->ddev.dev = dev;
> > INIT_LIST_HEAD(&cdd->ddev.channels);
> > cpp41_dma_info.dma_cap = cdd->ddev.cap_mask;
> Along with this please set src/dstn_addr_widths and residue_granularity
> please
will do.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-09 15:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-25 22:54 [PATCH] dma: cppi41: add missing directions bitfield Felipe Balbi
2015-03-04 12:43 ` Vinod Koul
2015-03-09 15:50 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).