From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCHv3 08/35] clk: ti: fix ti_clk_get_reg_addr error handling Date: Tue, 17 Mar 2015 11:38:08 -0700 Message-ID: <20150317183808.GI31346@atomide.com> References: <1424891085-10392-1-git-send-email-t-kristo@ti.com> <1424891085-10392-9-git-send-email-t-kristo@ti.com> <20150306191821.11109.2610@quantum> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from muru.com ([72.249.23.125]:38157 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754080AbbCQSmy (ORCPT ); Tue, 17 Mar 2015 14:42:54 -0400 Content-Disposition: inline In-Reply-To: <20150306191821.11109.2610@quantum> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Mike Turquette Cc: Tero Kristo , paul@pwsan.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org * Mike Turquette [150306 11:18]: > Quoting Tero Kristo (2015-02-25 11:04:18) > > There is a case where NULL can be a valid return value for > > ti_clk_get_reg_addr, specifically the case where both the provider index > > and register offsets are zero. In this case, the current error checking > > against a NULL pointer will fail. Thus, change the API to return a > > ERR_PTR value in an error case, and change all the users of this API to > > check against IS_ERR instead. > > > > Signed-off-by: Tero Kristo > > Cc: Michael Turquette > > Looks good to me. ... > > --- > > drivers/clk/ti/apll.c | 5 +++-- > > drivers/clk/ti/autoidle.c | 2 +- > > drivers/clk/ti/clk.c | 7 ++++--- > > drivers/clk/ti/divider.c | 4 ++-- > > drivers/clk/ti/dpll.c | 6 +++--- > > drivers/clk/ti/gate.c | 4 ++-- > > drivers/clk/ti/interface.c | 2 +- > > drivers/clk/ti/mux.c | 4 ++-- > > 8 files changed, 18 insertions(+), 16 deletions(-) Can this patch be queued separately by Mike or is there some dependency to this series? Other than wondering about the above and the dts related comments, this series works for me with PM tests. Regards, Tony