From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] arm: mach-omap2: remove superfluous NULL pointer check Date: Thu, 26 Mar 2015 10:34:19 -0700 Message-ID: <20150326173417.GA10805@atomide.com> References: <1426982418-9649-1-git-send-email-stefan@agner.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1426982418-9649-1-git-send-email-stefan@agner.ch> Sender: linux-kernel-owner@vger.kernel.org To: Stefan Agner Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, llvmlinux@lists.linuxfoundation.org List-Id: linux-omap@vger.kernel.org * Stefan Agner [150321 17:00]: > The NULL pointer check for superset->muxnames will always evaluate > true since muxnames is an array within struct omap_mux. Remove the > superfluous check to avoid warnings when using LLVM/clang. > > Signed-off-by: Stefan Agner Applying into omap-for-v4.1/fixes-not-urgent thanks. Tony > --- > For the reference, the warning generated by LLVM/clang: > arch/arm/mach-omap2/mux.c:1056:18: warning: address of array > 'superset->muxnames' will always evaluate to 'true' [-Wpointer-bool-conversion] > if (!superset->muxnames || !superset->muxnames[0]) { > ~~~~~~~~~~~^~~~~~~~ > > arch/arm/mach-omap2/mux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c > index 78064b0..176eef6 100644 > --- a/arch/arm/mach-omap2/mux.c > +++ b/arch/arm/mach-omap2/mux.c > @@ -1053,7 +1053,7 @@ static void __init omap_mux_init_list(struct omap_mux_partition *partition, > struct omap_mux *entry; > > #ifdef CONFIG_OMAP_MUX > - if (!superset->muxnames || !superset->muxnames[0]) { > + if (!superset->muxnames[0]) { > superset++; > continue; > } > -- > 2.3.3 >