From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Andy Lutomirski <luto@amacapital.net>,
Peter Neubauer <pneubauer@bluerwhite.org>,
Huang Rui <ray.huang@amd.com>, Jean Delvare <jdelvare@suse.de>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-api@vger.kernel.org
Subject: Re: [PATCH 86/86] usb/dwc3: move ids to pci_ids.h
Date: Mon, 30 Mar 2015 08:58:10 +0200 [thread overview]
Message-ID: <20150330065810.GA10508@kroah.com> (raw)
In-Reply-To: <20150330085001-mutt-send-email-mst@redhat.com>
On Mon, Mar 30, 2015 at 08:50:34AM +0200, Michael S. Tsirkin wrote:
> On Sun, Mar 29, 2015 at 10:42:00PM +0200, Greg Kroah-Hartman wrote:
> > On Sun, Mar 29, 2015 at 03:43:40PM +0200, Michael S. Tsirkin wrote:
> > > Comment says IDs should move to pci_ids.h, let's do it.
> >
> > No, please remove the comment, it's not needed in pci_ids.h at all.
>
> vendor ID does belong in pci_ids.h though, so says
> Documentation/PCI/pci.txt
Read the top of pci_ids.h please.
next prev parent reply other threads:[~2015-03-30 6:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1427635734-24786-1-git-send-email-mst@redhat.com>
2015-03-29 13:42 ` [PATCH 65/86] usb/dwc3: comment update Michael S. Tsirkin
[not found] ` <1427635734-24786-1-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-29 13:43 ` [PATCH 86/86] usb/dwc3: move ids to pci_ids.h Michael S. Tsirkin
[not found] ` <1427635734-24786-87-git-send-email-mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-29 20:42 ` Greg Kroah-Hartman
[not found] ` <20150329204200.GB5902-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-03-30 6:50 ` Michael S. Tsirkin
2015-03-30 6:58 ` Greg Kroah-Hartman [this message]
[not found] ` <20150330065810.GA10508-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-03-30 7:16 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150330065810.GA10508@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=balbi@ti.com \
--cc=bhelgaas@google.com \
--cc=jdelvare@suse.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mst@redhat.com \
--cc=pneubauer@bluerwhite.org \
--cc=ray.huang@amd.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox