From: Vinod Koul <vinod.koul@intel.com>
To: Petr Kulhavy <petr@barix.com>
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, peter.ujfalusi@ti.com,
linux-omap@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH 2/2] EDMA: TI: fixed wrongly initialized data parameter to the edma callback
Date: Wed, 1 Apr 2015 09:17:02 +0530 [thread overview]
Message-ID: <20150401034701.GV7192@intel.com> (raw)
In-Reply-To: <1427142901-16391-1-git-send-email-petr@barix.com>
On Mon, Mar 23, 2015 at 09:35:01PM +0100, Petr Kulhavy wrote:
> The "data" parameter passed indirectly to the edma_callback() should be
> edma_chan and not the dma_chan.
>
> This bug was so far harmless since the offset of struct dma_chan within struct
> edma_chan is 0. However as soon as someone changes struct edma_chan this would
> cause troubles.
Applied now, but do ensure you are using right subsystem anmes for patches.
I have fixed up now
--
~Vinod
prev parent reply other threads:[~2015-04-01 3:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 20:35 [PATCH 2/2] EDMA: TI: fixed wrongly initialized data parameter to the edma callback Petr Kulhavy
2015-03-24 10:07 ` Peter Ujfalusi
2015-04-01 3:47 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401034701.GV7192@intel.com \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=petr@barix.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).