From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: rtc-linux@googlegroups.com
Cc: a.zummo@towertech.it, t-kristo@ti.com, nsekhar@ti.com,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
lokeshvutla@ti.com
Subject: Re: [rtc-linux] [PATCH 3/3] rtc: omap: use module_platform_driver
Date: Wed, 1 Apr 2015 17:53:57 +0200 [thread overview]
Message-ID: <20150401155357.GE20669@piout.net> (raw)
In-Reply-To: <1427867698-1326-4-git-send-email-lokeshvutla@ti.com>
On 01/04/2015 at 11:24:58 +0530, Lokesh Vutla wrote :
> module_platform_driver_probe() prevents driver from requesting probe deferral.
> So using module_platform_drive() to support probe deferral.
>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/rtc/rtc-omap.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
> index 96cc613..a4965a0 100644
> --- a/drivers/rtc/rtc-omap.c
> +++ b/drivers/rtc/rtc-omap.c
> @@ -510,7 +510,7 @@ static const struct of_device_id omap_rtc_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, omap_rtc_of_match);
>
> -static int __init omap_rtc_probe(struct platform_device *pdev)
> +static int omap_rtc_probe(struct platform_device *pdev)
> {
> struct omap_rtc *rtc;
> struct resource *res;
> @@ -745,6 +745,7 @@ static void omap_rtc_shutdown(struct platform_device *pdev)
> }
>
> static struct platform_driver omap_rtc_driver = {
> + .probe = omap_rtc_probe,
> .remove = __exit_p(omap_rtc_remove),
> .shutdown = omap_rtc_shutdown,
> .driver = {
> @@ -755,7 +756,7 @@ static struct platform_driver omap_rtc_driver = {
> .id_table = omap_rtc_id_table,
> };
>
> -module_platform_driver_probe(omap_rtc_driver, omap_rtc_probe);
> +module_platform_driver(omap_rtc_driver);
>
> MODULE_ALIAS("platform:omap_rtc");
> MODULE_AUTHOR("George G. Davis (and others)");
> --
> 1.9.1
>
> --
> --
> You received this message because you are subscribed to "rtc-linux".
> Membership options at http://groups.google.com/group/rtc-linux .
> Please read http://groups.google.com/group/rtc-linux/web/checklist
> before submitting a driver.
> ---
> You received this message because you are subscribed to the Google Groups "rtc-linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-04-01 15:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 5:54 [PATCH 0/3] rtc: omap: Fix misc bugs Lokesh Vutla
2015-04-01 5:54 ` [PATCH 1/3] rtc: omap: Unlock and Lock rtc registers before and after register writes Lokesh Vutla
2015-04-01 15:52 ` [rtc-linux] " Alexandre Belloni
2015-04-02 11:12 ` Lokesh Vutla
2015-04-01 5:54 ` [PATCH 2/3] rtc: omap: Update Kconfig for OMAP RTC Lokesh Vutla
2015-04-01 15:52 ` [rtc-linux] " Alexandre Belloni
2015-04-01 5:54 ` [PATCH 3/3] rtc: omap: use module_platform_driver Lokesh Vutla
2015-04-01 15:53 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150401155357.GE20669@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nsekhar@ti.com \
--cc=rtc-linux@googlegroups.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).