From: Greg KH <gregkh@linuxfoundation.org>
To: Felipe Balbi <balbi@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
Bin Liu <binmlist@gmail.com>,
Brian Hutchinson <b.hutchman@gmail.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH 1/1] usb: musb: dsps: fix build on i386 when COMPILE_TEST is set
Date: Fri, 3 Apr 2015 19:10:42 +0200 [thread overview]
Message-ID: <20150403171042.GA30686@kroah.com> (raw)
In-Reply-To: <20150403151403.GA5503@saruman.tx.rr.com>
On Fri, Apr 03, 2015 at 10:14:14AM -0500, Felipe Balbi wrote:
> Hi Greg,
>
> On Wed, Mar 25, 2015 at 02:18:37PM -0700, Tony Lindgren wrote:
> > Commit 3e457371f436 ("usb: musb: Fix fifo reads for dm816x with musb_dsps")
> > fixed a USB error on dm816x, but introduced a new build error on i386
> > when COMPILE_TEST is set:
> >
> > drivers/usb/musb/musb_dsps.c: In function ‘dsps_read_fifo32’:
> > drivers/usb/musb/musb_dsps.c:624:3: error: implicit declaration of function
> > ‘readsl’ [-Werror=implicit-function-declaration]
> > readsl(fifo, dst, len >> 2);
> >
> > Let's fix this by using ioread32_rep() instead of readsl() as that's
> > more portable.
> >
> > Fixes: 3e457371f436 ("usb: musb: Fix fifo reads for dm816x with musb_dsps")
> > Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> > Cc: Bin Liu <binmlist@gmail.com>
> > Cc: Brian Hutchinson <b.hutchman@gmail.com>
> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> Can you apply this one directly ? It fixes a build error on i386.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
Now queued up, thanks.
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-04-03 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 21:18 [PATCH 1/1] usb: musb: dsps: fix build on i386 when COMPILE_TEST is set Tony Lindgren
2015-04-03 15:14 ` Felipe Balbi
2015-04-03 17:10 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150403171042.GA30686@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=b.hutchman@gmail.com \
--cc=balbi@ti.com \
--cc=binmlist@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox