From: Stephen Boyd <sboyd@codeaurora.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Tero Kristo <t-kristo@ti.com>,
Mike Turquette <mturquette@linaro.org>,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [RFT PATCH 1/8] clk: ti: dra7-atl-clock: Fix possible ERR_PTR dereference
Date: Thu, 14 May 2015 15:31:02 -0700 [thread overview]
Message-ID: <20150514223102.GA31753@codeaurora.org> (raw)
In-Reply-To: <1431500087-2275-2-git-send-email-k.kozlowski@samsung.com>
On 05/13, Krzysztof Kozlowski wrote:
> of_clk_get_from_provider() returns ERR_PTR on failure. The
> dra7-atl-clock driver was not checking its return value and immediately
> used it in __clk_get_hw(). __clk_get_hw() dereferences supplied clock,
> if it is not NULL, so in that case it would dereference an ERR_PTR.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: <stable@vger.kernel.org>
> Fixes: 9ac33b0ce81f ("CLK: TI: Driver for DRA7 ATL (Audio Tracking Logic)")
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-05-14 22:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 6:54 [RFT PATCH 0/8] clk: ti: Fix possible ERR_PTR dereferences from clk_get_sys Krzysztof Kozlowski
2015-05-13 6:54 ` [RFT PATCH 1/8] clk: ti: dra7-atl-clock: Fix possible ERR_PTR dereference Krzysztof Kozlowski
2015-05-14 22:31 ` Stephen Boyd [this message]
2015-05-13 6:54 ` [RFT PATCH 2/8] clk: ti: clk-2xxx: Prevent " Krzysztof Kozlowski
2015-05-13 6:54 ` [RFT PATCH 3/8] clk: ti: clk-3xxx: " Krzysztof Kozlowski
2015-05-13 6:54 ` [RFT PATCH 4/8] clk: ti: clk-33xx: " Krzysztof Kozlowski
2015-05-13 6:54 ` [RFT PATCH 5/8] clk: ti: clk-43xx: " Krzysztof Kozlowski
2015-05-13 6:54 ` [RFT PATCH 6/8] " Krzysztof Kozlowski
2015-05-13 6:54 ` [RFT PATCH 7/8] clk: ti: clk-54xx: " Krzysztof Kozlowski
2015-05-13 6:54 ` [RFT PATCH 8/8] clk: ti: clk-7xx: " Krzysztof Kozlowski
2015-05-13 7:07 ` [RFT PATCH 0/8] clk: ti: Fix possible ERR_PTR dereferences from clk_get_sys Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514223102.GA31753@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=stable@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).