From: Mark Brown <broonie@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Jyri Sarha <jsarha@ti.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, liam.r.girdwood@linux.intel.com,
bcousson@baylibre.com, misael.lopez@ti.com
Subject: Re: [PATCH] ASoC: davinci-mcasp: Choose PCM driver based on configured DMA controller
Date: Tue, 2 Jun 2015 11:46:27 +0100 [thread overview]
Message-ID: <20150602104627.GI14071@sirena.org.uk> (raw)
In-Reply-To: <556D8600.1060204@ti.com>
[-- Attachment #1: Type: text/plain, Size: 309 bytes --]
On Tue, Jun 02, 2015 at 01:31:28PM +0300, Peter Ujfalusi wrote:
> On 06/02/2015 11:58 AM, Jyri Sarha wrote:
> > +enum {
> > + MCASP_EDMA = 1,
> Why start from 1?
It's a fairly common style to ensure that zero initialised structures
don't have a default value. Don't know if that's the intent here or
not.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-06-02 10:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 8:58 [PATCH] ASoC: davinci-mcasp: Choose PCM driver based on configured DMA controller Jyri Sarha
2015-06-02 10:31 ` Peter Ujfalusi
2015-06-02 10:40 ` Jyri Sarha
2015-06-02 10:53 ` Peter Ujfalusi
2015-06-02 10:46 ` Mark Brown [this message]
2015-06-02 11:11 ` Jyri Sarha
2015-06-02 11:55 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150602104627.GI14071@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=jsarha@ti.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-omap@vger.kernel.org \
--cc=misael.lopez@ti.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).