From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 05/12] ARM: OMAP2+: Add support for initializing dm814x clocks Date: Thu, 4 Jun 2015 15:28:24 -0700 Message-ID: <20150604222823.GC30984@atomide.com> References: <1433348601-8966-1-git-send-email-tony@atomide.com> <1433348601-8966-6-git-send-email-tony@atomide.com> <20150604184254.GJ490@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from muru.com ([72.249.23.125]:55985 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751672AbbFDW20 (ORCPT ); Thu, 4 Jun 2015 18:28:26 -0400 Content-Disposition: inline In-Reply-To: <20150604184254.GJ490@codeaurora.org> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Stephen Boyd Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Matthijs van Duin , Mike Turquette , Paul Walmsley , Tero Kristo * Stephen Boyd [150604 11:44]: > On 06/03, Tony Lindgren wrote: > > diff --git a/drivers/clk/ti/clk-814x.c b/drivers/clk/ti/clk-814x.c > > new file mode 100644 > > index 0000000..bd2353c > > --- /dev/null > > +++ b/drivers/clk/ti/clk-814x.c > > @@ -0,0 +1,36 @@ > > +/* > > + * This program is free software; you can redistribute it and/or > > + * modify it under the terms of the GNU General Public License as > > + * published by the Free Software Foundation version 2. > > + */ > > + > > +#include > > +#include > > Is list.h used? > > > +#include > > +#include > > + > > +static struct ti_dt_clk dm814_clks[] = { > > + DT_CLK(NULL, "devosc_ck", "devosc_ck"), > > + DT_CLK(NULL, "mpu_ck", "mpu_ck"), > > + DT_CLK(NULL, "sysclk4_ck", "sysclk4_ck"), > > + DT_CLK(NULL, "sysclk6_ck", "sysclk6_ck"), > > + DT_CLK(NULL, "sysclk10_ck", "sysclk10_ck"), > > + DT_CLK(NULL, "sysclk18_ck", "sysclk18_ck"), > > + DT_CLK(NULL, "timer_sys_ck", "devosc_ck"), > > + DT_CLK(NULL, "cpsw_125mhz_gclk", "cpsw_125mhz_gclk"), > > + DT_CLK(NULL, "cpsw_cpts_rft_clk", "cpsw_cpts_rft_clk"), > > + { .node_name = NULL }, > > +}; > > + > > +static const char *enable_init_clks[] = { > > +}; > > delete? > > > + > > +int __init dm814x_dt_clk_init(void) > > +{ > > + ti_dt_clocks_register(dm814_clks); > > + omap2_clk_disable_autoidle_all(); > > + omap2_clk_enable_init_clocks(enable_init_clks, > > + ARRAY_SIZE(enable_init_clks)); > > And pass NULL and 0 here? Sure will remove, we can add those back once the PLL parts are working and if/when some boot time clocks are needed. Thanks. Tony