From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
"Pali Rohár" <pali.rohar@gmail.com>,
"Rob Herring" <robherring2@gmail.com>,
"Russell King" <linux@arm.linux.org.uk>,
"Will Deacon" <will.deacon@arm.com>,
"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Sebastian Reichel" <sre@debian.org>,
"Pavel Machek" <pavel@ucw.cz>,
"Andreas Färber" <afaerber@suse.de>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm: devtree: Save atags if are in DT atags field
Date: Wed, 24 Jun 2015 22:06:04 -0700 [thread overview]
Message-ID: <20150625050604.GM4156@atomide.com> (raw)
In-Reply-To: <2802980.ITgIdpK9OB@wuerfel>
* Arnd Bergmann <arnd@arndb.de> [150515 13:11]:
> On Friday 15 May 2015 21:50:06 Pali Rohár wrote:
> > @@ -256,5 +257,10 @@ const struct machine_desc * __init setup_machine_fdt(unsigned int dt_phys)
> > system_rev = 0;
> > }
> >
> > + /* Save atags */
> > + prop = of_get_flat_dt_prop(dt_root, "atags", NULL);
> > + if (prop)
> > + save_atags((void *)prop);
> > +
> > return mdesc;
> >
>
> How about checking whether this is actually running on the one board
> that needs it first?
>
> I'd rather not introduce something that may end up being considered
> an ABI on other machines.
It seems having this within CONFIG_ARM_ATAG_DTB_COMPAT should be
enough here.
Regards,
Tony
next prev parent reply other threads:[~2015-06-25 5:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 8:49 [RESEND] [PATCH v2 0/2] ARM: /proc/cpuinfo: DT: Add support for Revision Pali Rohár
2015-05-06 8:49 ` [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision Pali Rohár
2015-05-06 9:31 ` Arnd Bergmann
2015-05-06 10:37 ` Pali Rohár
2015-05-06 11:04 ` Arnd Bergmann
2015-05-06 11:44 ` Pali Rohár
2015-06-25 5:01 ` Tony Lindgren
2015-06-25 7:18 ` Pali Rohár
2015-06-25 7:22 ` Tony Lindgren
2015-06-25 7:27 ` Pali Rohár
2015-06-25 7:41 ` Tony Lindgren
[not found] ` <20150625050138.GL4156-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-07-06 12:23 ` Pali Rohár
2015-07-06 12:31 ` Tony Lindgren
[not found] ` <20150706123126.GG10705-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-07-06 13:12 ` Pali Rohár
2015-07-06 13:55 ` Tony Lindgren
2015-07-06 15:22 ` Rob Herring
[not found] ` <CAL_Jsq+ysDqxTgfW1JvG5czHa4UkZQDv1BN63iK4jvV9kDXM8w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-06 16:20 ` Pali Rohár
2015-07-06 16:36 ` Pali Rohár
2015-07-06 17:30 ` Rob Herring
2015-07-06 15:20 ` Rob Herring
2015-07-06 15:24 ` Tony Lindgren
2015-06-25 10:03 ` Russell King - ARM Linux
2015-05-06 8:49 ` [RESEND] [PATCH v2 2/2] arm: boot: convert ATAG_REVISION to DT revision field Pali Rohár
2015-05-15 19:50 ` [PATCH 0/2] ARM: /proc/atags: Export also for DT Pali Rohár
2015-05-15 19:50 ` [PATCH 1/2] arm: devtree: Save atags if are in DT atags field Pali Rohár
2015-05-15 20:09 ` Arnd Bergmann
2015-06-25 5:06 ` Tony Lindgren [this message]
2015-05-15 19:50 ` [PATCH 2/2] arm: boot: store ATAG structure into " Pali Rohár
2015-05-15 20:12 ` Arnd Bergmann
2015-05-15 20:16 ` Pali Rohár
2015-05-15 20:21 ` Arnd Bergmann
2015-06-25 5:12 ` Tony Lindgren
2015-06-25 10:02 ` [PATCH 0/2] ARM: /proc/atags: Export also for DT Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150625050604.GM4156@atomide.com \
--to=tony@atomide.com \
--cc=afaerber@suse.de \
--cc=arnd@arndb.de \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=robherring2@gmail.com \
--cc=sre@debian.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).